Open
Conversation
derrod
force-pushed
the
no-codec-strings-attached
branch
from
48bfd05 to
2977f18
Compare
tt2468
reviewed
Jun 20, 2024
|
|
||
| #### Drawbacks | ||
|
|
||
| - Requires libobs API changes to add new codecs |
Member
There was a problem hiding this comment.
Wouldn't all three solutions require libobs API changes?
Contributor
There was a problem hiding this comment.
The third requires to modify the API at each codec addition unlike the two others that relies on a third-party enum or FourCC (not an enum but integers).
derrod
force-pushed
the
no-codec-strings-attached
branch
from
2977f18 to
83b8cdb
Compare
derrod
force-pushed
the
no-codec-strings-attached
branch
from
83b8cdb to
dd3528d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This RFC intends to facilitate discussion to find a way to move away from storing codec identifiers as strings. This is to avoid string comparisons and remove some redundancies such as outputs defining their own codec enumerations.
Motivation and Context
String comparisons are slow, error prone (case sensitivity, typos, etc.), and generally ugly. Most outputs convert from strings to internal enumerations anyway which could be made redundant by providing them in the first place.
Link to RFC