frontend: Fix warning for themeWatcher#13259
Open
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Open
frontend: Fix warning for themeWatcher#13259Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Conversation
3ffba70 to
65073b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Qt warning during startup when the AutoReload setting for themes is enabled.
setTheme calls
themeWatcher->removePathsand when the theme is first set upthemeWatcher->files()is empty.Any other time except when the theme is first being set up this call will be fine, so the setup of themeWatcher is moved after the first setTheme call.
Motivation and Context
Warnings are bad. Found using QT_FATAL_WARNINGS
How Has This Been Tested?
Built and launched OBS, no more warning.
Types of changes
Checklist: