-
Notifications
You must be signed in to change notification settings - Fork 34
Add specific bronchopulmonary segment terms for HCA lung dataset #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ung dataset Added comprehensive set of bronchopulmonary segment terms requested for CELLxGENE curation: Right lung (10 segments): - Upper lobe: apical, posterior, anterior - Middle lobe: lateral, medial - Lower lobe: superior, medial basal, anterior basal, lateral basal, posterior basal Left lung (8 segments): - Upper lobe: apical-posterior, anterior, superior lingular, inferior lingular - Lower lobe: superior, antero-medial basal, lateral basal, posterior basal Each term includes: - Logical definitions with intersection_of axioms linking segments to their parent lung lobes - References to PMID:18271171 for anatomical definitions - Proper metadata including contributor attribution (Gloria S. Pryhuber), timestamps, and issue tracking - Standard synonyms including segment numbers (S1-S10) These terms provide the anatomical granularity needed for lung sample annotation in HCA datasets. Fixes #3444 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> @dragon-ai-agent
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 18 right anterior bronchopulmonary segmentNo changes in inferred subclasses. left inferior lingular bronchopulmonary segmentNo changes in inferred subclasses. right lateral bronchopulmonary segmentNo changes in inferred subclasses. left superior bronchopulmonary segmentNo changes in inferred subclasses. right medial bronchopulmonary segmentNo changes in inferred subclasses. left antero-medial basal bronchopulmonary segmentNo changes in inferred subclasses. right superior bronchopulmonary segmentNo changes in inferred subclasses. left lateral basal bronchopulmonary segmentNo changes in inferred subclasses. right medial basal bronchopulmonary segmentNo changes in inferred subclasses. left posterior basal bronchopulmonary segmentNo changes in inferred subclasses. right anterior basal bronchopulmonary segmentNo changes in inferred subclasses. right lateral basal bronchopulmonary segmentNo changes in inferred subclasses. right posterior basal bronchopulmonary segmentNo changes in inferred subclasses. left apical-posterior bronchopulmonary segmentNo changes in inferred subclasses. right apical bronchopulmonary segmentNo changes in inferred subclasses. left anterior bronchopulmonary segmentNo changes in inferred subclasses. right posterior bronchopulmonary segmentNo changes in inferred subclasses. left superior lingular bronchopulmonary segmentNo changes in inferred subclasses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large scale logical changes detected. Review by specific Uberon Core Team members is required.
|
#gogoeditdiff |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
I'm okay with these additions but I don't think I'm the one being asked. Let me know if I'm needed to do anything further for this to move ahead. Thank you |
Summary
This PR adds 18 new bronchopulmonary segment terms to support anatomical annotation of lung samples in the Human Cell Atlas (HCA) CELLxGENE dataset, as requested in #3444.
Terms Added
Right lung (10 segments):
Left lung (8 segments):
Term Structure
Each term includes:
Openly Licensed Images
For illustration purposes, I identified several openly licensed resources:
Wikipedia/Wikimedia Commons: The Wikipedia article on bronchopulmonary segments contains images under Creative Commons Attribution-ShareAlike 4.0 License, including:
PMC Open Access Article: "Application of 3D-printed pulmonary segment specimens in experimental teaching of sectional anatomy" (PMC10157950) is licensed under CC BY 4.0 and contains detailed anatomical images of bronchopulmonary segments.
Radiopaedia: While specific licensing details would need verification, Radiopaedia has annotated CT images showing bronchopulmonary segments: https://radiopaedia.org/cases/bronchopulmonary-segments-annotated-ct-2
Pulmonary Arterial Branches
As noted in the issue comments by @gpryhuber, each bronchopulmonary segment is supplied by its own bronchus and pulmonary arterial branch. This anatomical organization allows segments to be functionally and anatomically discrete, permitting surgical resection of individual segments. While I didn't add specific arterial branch relationships in this initial implementation (as detailed pulmonary arterial terminology would need to be verified/added to UBERON first), this could be a future enhancement.
Clinical Significance
As noted by @gpryhuber, bronchopulmonary segments are particularly important in:
Fixes #3444
🤖 Generated with Claude Code
@dragon-ai-agent