fix: resolve CI lint, build, and test failures#500
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Disable storybook/no-renderer-packages lint rule (all stories use @storybook/react) - Fix PageView.tsx to preserve original page type instead of hardcoding 'page' - Exclude test files from plugin-view DTS generation to fix Storybook build TS errors - Remove unused imports in plugin-list (ListViewSchema, beforeAll, ComponentRegistry, path) Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI errors in build and test process
fix: resolve CI lint, build, and test failures
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves multiple CI failures caused by a storybook eslint rule upgrade, a type override bug in PageView, and DTS including test files. The changes are focused on build and lint configuration fixes that align with established project conventions.
Changes:
- Disable
storybook/no-renderer-packageseslint rule for story files, matching the project's established pattern where all 70+ stories import types from@storybook/react - Fix PageView to preserve the original page type (e.g., 'app', 'utility', 'home') instead of always overwriting with 'page', supporting the multi-type PageRenderer registration pattern
- Exclude test files from vite-plugin-dts in plugin-view, following the same pattern already established in plugin-kanban to prevent build errors from jest-dom matchers
- Remove unused imports from plugin-list package
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.js | Adds override to disable storybook/no-renderer-packages rule for story files, aligning with project convention of importing types from @storybook/react |
| apps/console/src/components/PageView.tsx | Preserves original page type from config instead of hardcoding 'page', supporting the PageRenderer's multi-type registration ('app', 'page', 'utility', 'home', 'record') |
| packages/plugin-view/vite.config.ts | Excludes test files from DTS generation to prevent build errors from jest-dom matcher types, matching plugin-kanban pattern |
| packages/plugin-list/src/index.tsx | Removes unused ListViewSchema import |
| packages/plugin-list/src/registration.test.tsx | Removes unused beforeAll and ComponentRegistry imports |
| packages/plugin-list/vitest.config.ts | Removes unused path import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple CI jobs (Lint, Build, Test, Storybook) failing on main due to a storybook eslint rule upgrade, a type override bug in PageView, and DTS including test files.
Changes
storybook/no-renderer-packagesrule via post-storybook override — all 70+ story files import types from@storybook/react, which is the established project conventiontypefrom config instead of unconditionally overwriting with'page':vite-plugin-dtsgeneration — jest-dom matchers (toBeInTheDocument, etc.) lack type declarations during build, matching the pattern already used inplugin-kanbanListViewSchema,beforeAll,ComponentRegistry,path) across index, test, and config filesOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.