Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…PageView type conflict Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot stopped work on behalf of
hotlong due to an error
February 13, 2026 17:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical build errors by removing unsupported properties from object schema definitions and correcting a TypeScript error in the PageView component. The changes ensure strict compliance with @objectstack/spec, which defines ObjectSchema to only accept specific properties (name, label, description, fields, permissions, triggers, etc.) - not view-related configurations like list_views, form_views, or actions.
Changes:
- Fixed PageView.tsx to prevent
typeproperty from being overwritten by moving it after the spread operator - Removed unsupported
list_viewsproperty from 10 object definitions (all CRM objects and kitchen-sink examples) - Removed unsupported
form_viewsandactionsproperties from showcase.object.ts
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/console/src/components/PageView.tsx | Fixed property ordering: moved type: 'page' after spread to prevent overwriting |
| examples/kitchen-sink/src/objects/showcase.object.ts | Removed unsupported list_views, form_views, and actions properties from ObjectSchema |
| examples/kitchen-sink/src/objects/kitchen_sink.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/user.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/project.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/product.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/order.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/opportunity.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/event.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/contact.object.ts | Removed unsupported list_views property from ObjectSchema |
| examples/crm/src/objects/account.object.ts | Removed unsupported list_views property from ObjectSchema |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Build and Test Issues
Build Issues Identified:
Test Issues:
Changes Made:
list_viewsproperty from 10 object definitions (CRM and kitchen-sink examples)form_viewsproperty from showcase objectactionsproperty from showcase objectBuild Status: ✅ All 42 tasks successful
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.