-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade @objectstack to v2.0.4, add plugin-auth for server-side authentication #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f586610
Initial plan
Copilot 7dea6de
feat: upgrade @objectstack to latest and add plugin-auth for server-s…
Copilot 1a9bea1
docs: clarify dev-only fallback secret in CRM example server
Copilot 771fd19
fix: add crypto external for Vite builds to support @objectstack/core…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,8 +1,9 @@ | ||||||
| # @objectstack/client Evaluation for Low-Code App UI Development | ||||||
|
|
||||||
| > **Date:** February 10, 2026 | ||||||
| > **Spec Version:** @objectstack/spec v2.0.1 | ||||||
| > **Client Version:** @objectstack/client v2.0.1 | ||||||
| > **Spec Version:** @objectstack/spec v2.0.4 | ||||||
| > **Client Version:** @objectstack/client v2.0.4 | ||||||
| > **Auth Plugin Version:** @objectstack/plugin-auth v2.0.3 | ||||||
| > **ObjectUI Version:** v0.5.x | ||||||
| > **Scope:** Evaluate whether @objectstack/client can fully support developing a complete low-code application UI based on the @objectstack/spec protocol | ||||||
|
|
||||||
|
|
@@ -104,6 +105,7 @@ The @objectstack/spec defines `ActionSchema` with 5 action types: | |||||
|
|
||||||
| | Capability | Implementation | Client Dependency | Status | | ||||||
| |------------|---------------|-------------------|--------| | ||||||
| | **Server-Side Auth** | `@objectstack/plugin-auth` (AuthPlugin) | ObjectKernel plugin | ✅ Complete | | ||||||
| | **Token Authentication** | `ObjectStackAdapter({ token })` | Client constructor | ✅ Complete | | ||||||
| | **Dynamic Token Injection** | `ObjectStackAdapter({ fetch })` | Custom fetch wrapper | ✅ Complete | | ||||||
| | **Session Management** | `@object-ui/auth` (AuthProvider) | better-auth integration | ✅ Complete | | ||||||
|
|
@@ -114,7 +116,7 @@ The @objectstack/spec defines `ActionSchema` with 5 action types: | |||||
| | **OAuth/SSO** | better-auth plugins | External auth providers | ✅ Complete | | ||||||
| | **Multi-Factor Auth** | better-auth 2FA plugin | External auth providers | ✅ Available | | ||||||
|
|
||||||
| **Auth Assessment: 100% — Full auth stack is implemented via @object-ui/auth + better-auth.** | ||||||
| **Auth Assessment: 100% — Full auth stack is implemented. Server-side via @objectstack/plugin-auth (better-auth powered, ObjectQL persistence). Client-side via @object-ui/auth + better-auth.** | ||||||
|
|
||||||
| ### 2.6 Multi-Tenancy | ||||||
|
|
||||||
|
|
@@ -170,6 +172,19 @@ A complete low-code app built on @objectstack/spec follows this data flow: | |||||
| │ │ │ | ||||||
| │ ▼ │ | ||||||
| │ ┌──────────────────────────────────────────────────────────────┐ │ | ||||||
| │ │ ObjectStack Server │ │ | ||||||
| │ │ │ │ | ||||||
| │ │ ObjectKernel │ │ | ||||||
| │ │ ├── ObjectQLPlugin (query engine) │ │ | ||||||
| │ │ ├── DriverPlugin (data storage) │ │ | ||||||
| │ │ ├── AuthPlugin (@objectstack/plugin-auth) │ │ | ||||||
| │ │ │ └── better-auth (session, OAuth, 2FA, passkeys) │ │ | ||||||
| │ │ ├── HonoServerPlugin (HTTP /api/v1/*) │ │ | ||||||
| │ │ └── AppPlugin (stack config) │ │ | ||||||
| │ └──────────────────────────────────────────────────────────────┘ │ | ||||||
| │ │ │ | ||||||
| │ ▼ │ | ||||||
| │ ┌──────────────────────────────────────────────────────────────┐ │ | ||||||
| │ │ ObjectUI Runtime │ │ | ||||||
| │ │ │ │ | ||||||
| │ │ AuthProvider → PermissionProvider → TenantProvider │ │ | ||||||
|
|
@@ -208,7 +223,7 @@ A complete low-code app built on @objectstack/spec follows this data flow: | |||||
| | **Validation Rules** | `Data.Validation` | Server + client-side | `@object-ui/core` | ✅ Yes | | ||||||
| | **Permissions/RBAC** | `Security.RBAC` | Role data from server | `@object-ui/permissions` | ✅ Yes | | ||||||
| | **Multi-Tenancy** | `System.Tenant` | X-Tenant-ID header | `@object-ui/tenant` | ✅ Yes | | ||||||
| | **Authentication** | `Identity.Auth` | Token via custom fetch | `@object-ui/auth` | ✅ Yes | | ||||||
| | **Authentication** | `Identity.Auth` | Token via custom fetch | `@object-ui/auth` + `@objectstack/plugin-auth` | ✅ Yes | | ||||||
| | **i18n** | `Shared.i18n` | None (client-side) | `@object-ui/i18n` | ✅ Yes | | ||||||
| | **Theming** | `UI.Theme` | None (client-side) | Theme Provider | ✅ Yes | | ||||||
| | **AI Assistance** | `AI.Config` | AI API endpoints | `plugin-ai` | ✅ Yes | | ||||||
|
|
@@ -291,7 +306,49 @@ export default defineStack({ | |||||
| }); | ||||||
| ``` | ||||||
|
|
||||||
| ### 5.2 Runtime Initialization | ||||||
| ### 5.2 Server-Side Setup (with @objectstack/plugin-auth) | ||||||
|
|
||||||
| ```typescript | ||||||
| // server.ts — Bootstrap the ObjectStack server with authentication | ||||||
| import { ObjectKernel } from '@objectstack/core'; | ||||||
| import { ObjectQLPlugin } from '@objectstack/objectql'; | ||||||
| import { AppPlugin, DriverPlugin } from '@objectstack/runtime'; | ||||||
| import { HonoServerPlugin } from '@objectstack/plugin-hono-server'; | ||||||
| import { InMemoryDriver } from '@objectstack/driver-memory'; | ||||||
| import { AuthPlugin } from '@objectstack/plugin-auth'; | ||||||
| import config from './objectstack.config'; | ||||||
|
|
||||||
| async function startServer() { | ||||||
| const kernel = new ObjectKernel(); | ||||||
|
|
||||||
| // Core engine + data driver | ||||||
| await kernel.use(new ObjectQLPlugin()); | ||||||
| await kernel.use(new DriverPlugin(new InMemoryDriver())); | ||||||
|
|
||||||
| // Application stack | ||||||
| await kernel.use(new AppPlugin(config)); | ||||||
|
|
||||||
| // Authentication via @objectstack/plugin-auth | ||||||
| // Provides /api/v1/auth/* endpoints (sign-in, sign-up, session, OAuth, 2FA, etc.) | ||||||
| await kernel.use(new AuthPlugin({ | ||||||
| secret: process.env.AUTH_SECRET || 'dev-secret', | ||||||
| baseUrl: 'http://localhost:3000', | ||||||
| providers: [ | ||||||
| // Optional: OAuth providers | ||||||
| // { id: 'google', clientId: '...', clientSecret: '...' }, | ||||||
| ], | ||||||
| })); | ||||||
|
|
||||||
| // HTTP server | ||||||
| await kernel.use(new HonoServerPlugin({ port: 3000 })); | ||||||
|
|
||||||
| await kernel.bootstrap(); | ||||||
| } | ||||||
|
|
||||||
| startServer(); | ||||||
| ``` | ||||||
|
|
||||||
| ### 5.3 Runtime Initialization | ||||||
|
|
||||||
| ```typescript | ||||||
| // App.tsx — Bootstrap the low-code runtime | ||||||
|
|
@@ -312,7 +369,7 @@ function App() { | |||||
| }); | ||||||
|
|
||||||
| return ( | ||||||
| <AuthProvider authUrl="/api/auth"> | ||||||
| <AuthProvider authUrl="/api/v1/auth"> | ||||||
|
||||||
| <AuthProvider authUrl="/api/v1/auth"> | |
| <AuthProvider authUrl="/api/auth"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ import { ObjectQLPlugin } from '@objectstack/objectql'; | |
| import { AppPlugin, DriverPlugin } from '@objectstack/runtime'; | ||
| import { HonoServerPlugin } from '@objectstack/plugin-hono-server'; | ||
| import { InMemoryDriver } from '@objectstack/driver-memory'; | ||
| import { AuthPlugin } from '@objectstack/plugin-auth'; | ||
| import config from './objectstack.config'; | ||
| import { pino } from 'pino'; | ||
| import { ConsolePlugin } from './console-plugin'; | ||
|
|
@@ -42,11 +43,19 @@ async function startServer() { | |
| const appPlugin = new AppPlugin(config); | ||
| await kernel.use(appPlugin); | ||
|
|
||
| // 4. HTTP Server | ||
| // 4. Authentication (via @objectstack/plugin-auth) | ||
| // NOTE: In production, always set AUTH_SECRET env var. The fallback is for local development only. | ||
| const authPlugin = new AuthPlugin({ | ||
| secret: process.env.AUTH_SECRET || 'objectui-dev-secret', | ||
| baseUrl: 'http://localhost:3000', | ||
| }); | ||
|
Comment on lines
+47
to
+51
|
||
| await kernel.use(authPlugin); | ||
|
|
||
| // 5. HTTP Server | ||
| const serverPlugin = new HonoServerPlugin({ port: 3000 }); | ||
| await kernel.use(serverPlugin); | ||
|
|
||
| // 5. Console Plugin | ||
| // 6. Console Plugin | ||
| const consolePlugin = new ConsolePlugin(); | ||
| await kernel.use(consolePlugin); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server-side setup example uses
secret: process.env.AUTH_SECRET || 'dev-secret'. Similar to the CRM server code, a hard-coded fallback secret is unsafe and can be copied into production accidentally. Prefer failing fast whenAUTH_SECRETis missing (or gating any fallback behind an explicit dev-only check) and mention required env vars in the example text.