Fix TransactionManager type mismatch and ConditionalAuthWrapper import paths#428
Merged
Fix TransactionManager type mismatch and ConditionalAuthWrapper import paths#428
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…nditionalAuthWrapper import paths Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all CI build and test errors
Fix TransactionManager type mismatch and ConditionalAuthWrapper import paths
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI failures by aligning TransactionManager’s action executor type with the enhanced UI action schema, and by correcting broken relative imports in the console’s conditional auth wrapper.
Changes:
- Update
TransactionManager.executeTransaction()to acceptUIActionSchema(enhanced action schema) instead of legacy CRUDActionSchema. - Fix
ConditionalAuthWrapperrelative import paths forObjectStackAdapterandLoadingScreen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/actions/TransactionManager.ts | Uses UIActionSchema for actionExecutor to match TransactionConfig.actions and resolve the TS2345 build error. |
| apps/console/src/components/ConditionalAuthWrapper.tsx | Corrects relative imports to match the file’s actual location under components/, resolving console test failures. |
Contributor
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three CI jobs (Test, Build Core, Build Docs) fail due to a type error in
@object-ui/corebuild, and two console tests fail due to broken imports.Build error:
TransactionManager.ts(TS2345)TransactionConfig.actionsis typed asActionSchema[]fromui-action.ts, but theactionExecutorcallback parameter used the legacyActionSchemafromcrud.ts. These are incompatible (type: ActionTypevstype: 'action').Test failures:
ConditionalAuthWrapper.tsxTwo wrong relative imports — the file is in
components/but referenced paths as if it were insrc/:'./dataSource'→'../dataSource''./components/LoadingScreen'→'./LoadingScreen'💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.