Fix CI build and test errors by Copilot · Pull Request #952 · objectstack-ai/framework

Copilot · 2026-03-22T07:34:47Z

CI pipeline broken on main — build fails in service-analytics (TS6133), tests fail in nextjs adapter and plugin-auth due to stale test assertions.

Build fix

service-analytics/native-sql-strategy.ts: Remove unused measure variable that fails noUnusedLocals: true. The variable was a leftover from copy-pasting the dimensions block — measures always hardcode type 'number'.

Test fixes

nextjs/metadata-api.test.ts (9 tests): Assertions used old dispatch(subPath, context, method, body) signature. Updated to match current implementation:

// before
expect(mockDispatcher.dispatch).toHaveBeenCalledWith('objects', expect.objectContaining({ request: expect.anything() }), 'GET', undefined);
// after
expect(mockDispatcher.dispatch).toHaveBeenCalledWith('GET', '/meta/objects', undefined, {}, expect.objectContaining({ request: expect.anything() }));

plugin-auth/auth-plugin.test.ts (2 tests): .mock.calls.at(-1)[1] resolved to the app.com.objectstack.system service object (second registerService call), not the AuthManager. Added mockClear() before localPlugin.init() so mock.calls[0][1] reliably references the correct AuthManager instance.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

vercel · 2026-03-22T07:34:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
objectstack-play	Ready	Preview, Comment	Mar 22, 2026 8:24am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
spec	Ignored		Mar 22, 2026 8:24am

- Remove unused 'measure' variable in native-sql-strategy.ts (TS6133) - Update nextjs adapter tests to match current dispatch() signature - Fix auth-plugin tests to reference correct AuthManager instance Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/39b2f206-d4bb-4357-98ac-f5f9e1466455

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/39b2f206-d4bb-4357-98ac-f5f9e1466455

Copilot

Pull request overview

Fixes CI breakages on main by addressing a TypeScript unused-local build failure and updating failing tests to match current runtime behavior (notably the HttpDispatcher.dispatch() signature).

Changes:

Removed an unused variable in service-analytics that caused TS6133 under noUnusedLocals.
Updated Next.js adapter metadata API tests to assert against the current dispatch(method, path, body, queryParams, context) call shape.
Stabilized plugin-auth tests by clearing registerService mock call history before re-initializing a local plugin instance.
Documented the fixes in CHANGELOG.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.

File	Description
packages/services/service-analytics/src/strategies/native-sql-strategy.ts	Removes unused locals to unblock TypeScript build with strict unused checks.
packages/plugins/plugin-auth/src/auth-plugin.test.ts	Fixes stale assertions by ensuring `registerService` mock calls reference the intended plugin instance.
packages/adapters/nextjs/src/metadata-api.test.ts	Updates assertions to match current Next.js adapter → dispatcher call signature.
CHANGELOG.md	Records CI build/test fixes for traceability.

Copilot · 2026-03-22T08:42:23Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/views',
          undefined,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


This assertion hard-codes the query params arg to {}. Consider loosening it to expect.any(Object) / expect.objectContaining({}) to avoid brittleness if the adapter later adds default query keys.

Copilot · 2026-03-22T08:42:23Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/agents',
          undefined,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


Query params are asserted as a literal {} here; consider expect.any(Object) / expect.objectContaining({}) to keep this test less coupled to internal query parsing details and aligned with other Next.js adapter tests.

Copilot · 2026-03-22T08:42:23Z

packages/adapters/nextjs/src/metadata-api.test.ts

+        '/meta/objects/account/fields/name',
        undefined,
+        {},
+        expect.objectContaining({ request: expect.anything() }),
      );


This assertion fixes the dispatch signature, but it also hard-codes query params to {}. Using expect.any(Object) (as in packages/adapters/nextjs/src/nextjs.test.ts) makes the test more resilient if query parsing behavior changes.

Copilot · 2026-03-22T08:42:24Z

packages/adapters/nextjs/src/metadata-api.test.ts

+        '/meta',
        undefined,
+        {},
+        expect.objectContaining({ request: expect.anything() }),
      );


Same as the other dispatch assertions: the query params argument is asserted as {}. Consider loosening this to expect.any(Object) / expect.objectContaining({}) to avoid test brittleness and keep consistency with other adapter tests.

Copilot · 2026-03-22T08:42:24Z

packages/plugins/plugin-auth/src/auth-plugin.test.ts

+      const registeredAuthManager = (mockContext.registerService as any).mock.calls[0][1];
      const setRuntimeSpy = vi.spyOn(registeredAuthManager, 'setRuntimeBaseUrl');



Same as above: relying on registerService.mock.calls[0] assumes init() always registers the AuthManager first. Consider selecting the call where the first argument is 'auth' to keep this test resilient if service registration order changes.

Copilot · 2026-03-22T08:42:24Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/flows',
          undefined,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


This test asserts the query params argument is exactly {}. For consistency with nextjs.test.ts and to reduce brittleness, prefer expect.any(Object) / expect.objectContaining({}).

Copilot · 2026-03-22T08:42:24Z

packages/plugins/plugin-auth/src/auth-plugin.test.ts

+      const registeredAuthManager = (mockContext.registerService as any).mock.calls[0][1];
      const setRuntimeSpy = vi.spyOn(registeredAuthManager, 'setRuntimeBaseUrl');



Indexing into registerService.mock.calls[0][1] still relies on the ordering of init() registrations (currently auth first, then app.com.objectstack.system). To make the test more robust against future ordering changes, consider locating the call by service name (first arg === 'auth') rather than relying on [0].

Copilot · 2026-03-22T08:42:24Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/objects/account',
          undefined,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


The 4th arg to dispatch() is the query params object; asserting a literal {} is brittle and differs from the pattern in packages/adapters/nextjs/src/nextjs.test.ts (uses expect.any(Object)). Consider loosening this assertion to avoid future failures if query parsing adds defaults.

Copilot · 2026-03-22T08:42:25Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/objects',
          body,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


Same as above: using a literal {} for the query params arg makes the assertion more fragile than necessary. Prefer expect.any(Object) / expect.objectContaining({}) like other Next.js adapter tests.

Copilot · 2026-03-22T08:42:25Z

packages/adapters/nextjs/src/metadata-api.test.ts

+          '/meta/objects/account',
          body,
+          {},
+          expect.objectContaining({ request: expect.anything() }),
        );


Same concern: the query params argument is asserted as {}. Using expect.any(Object) would keep this test consistent with other adapter tests and less sensitive to internal query parsing changes.

Initial plan

3d2eaa6

Copilot AI assigned Copilot and hotlong Mar 22, 2026

Copilot started work on behalf of hotlong March 22, 2026 07:34 View session

vercel bot deployed to Preview – objectstack-play March 22, 2026 07:36 View deployment

vercel bot deployed to Preview – objectstack-play March 22, 2026 07:58 View deployment

github-actions bot added tests size/s labels Mar 22, 2026

docs: update CHANGELOG.md with CI fix details

a9ffb71

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/39b2f206-d4bb-4357-98ac-f5f9e1466455

Copilot AI changed the title ~~[WIP] Fix CI build and test errors~~ Fix CI build and test errors Mar 22, 2026

Copilot AI requested a review from hotlong March 22, 2026 08:23

Copilot finished work on behalf of hotlong March 22, 2026 08:23

github-actions bot added the documentation Improvements or additions to documentation label Mar 22, 2026

vercel bot deployed to Preview – objectstack-play March 22, 2026 08:24 View deployment

hotlong marked this pull request as ready for review March 22, 2026 08:38

Copilot AI review requested due to automatic review settings March 22, 2026 08:38

hotlong merged commit 56066e4 into main Mar 22, 2026
13 checks passed

Copilot started reviewing on behalf of hotlong March 22, 2026 08:39 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CI build and test errors#952

Fix CI build and test errors#952
hotlong merged 3 commits intomainfrom
copilot/fix-ci-build-test-errors

Copilot AI commented Mar 22, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const registeredAuthManager = (mockContext.registerService as any).mock.calls[0][1];
		const setRuntimeSpy = vi.spyOn(registeredAuthManager, 'setRuntimeBaseUrl');

Conversation

Copilot AI commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build fix

Test fixes

Uh oh!

vercel bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 22, 2026 •

edited

Loading

vercel bot commented Mar 22, 2026 •

edited

Loading