-
Notifications
You must be signed in to change notification settings - Fork 1
Add granular query operation capabilities to driver schema #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
46d6487
Initial plan
Copilot 25cb777
Add query capability flags to driver and datasource schemas
Copilot cb37a43
Build: Update JSON schemas and documentation for driver capabilities
Copilot 4c80263
Fix: Correct spelling consistency (in-memory → in memory)
Copilot 8eb2e9f
Initial plan
Copilot 803f055
Fix: Update InMemoryDriver capabilities to match expanded schema
Copilot f1f81d9
Refine: Set capabilities to false for unimplemented features
Copilot 7767187
Merge pull request #51 from objectstack-ai/copilot/fix-action-run-issue
hotlong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,18 +51,50 @@ export const DriverDefinitionSchema = z.object({ | |
| * and what to compute in memory. | ||
| */ | ||
| export const DatasourceCapabilities = z.object({ | ||
| /** Can execute SQL-like joins natively? */ | ||
| joins: z.boolean().default(false), | ||
| // ============================================================================ | ||
| // Transaction & Connection Management | ||
| // ============================================================================ | ||
|
|
||
| /** Can handle ACID transactions? */ | ||
| transactions: z.boolean().default(false), | ||
|
|
||
| // ============================================================================ | ||
| // Query Operations | ||
| // ============================================================================ | ||
|
|
||
| /** Can execute WHERE clause filters natively? */ | ||
| queryFilters: z.boolean().default(false), | ||
|
|
||
| /** Can perform aggregation (group by, sum, avg)? */ | ||
| queryAggregations: z.boolean().default(false), | ||
|
|
||
| /** Can perform ORDER BY sorting? */ | ||
| querySorting: z.boolean().default(false), | ||
|
|
||
| /** Can perform LIMIT/OFFSET pagination? */ | ||
| queryPagination: z.boolean().default(false), | ||
|
|
||
| /** Can perform window functions? */ | ||
| queryWindowFunctions: z.boolean().default(false), | ||
|
|
||
| /** Can perform subqueries? */ | ||
| querySubqueries: z.boolean().default(false), | ||
|
Comment on lines
+65
to
+81
|
||
|
|
||
| /** Can execute SQL-like joins natively? */ | ||
| joins: z.boolean().default(false), | ||
|
|
||
| // ============================================================================ | ||
| // Advanced Features | ||
| // ============================================================================ | ||
|
|
||
| /** Can perform full-text search? */ | ||
| fullTextSearch: z.boolean().default(false), | ||
| /** Can perform aggregation (group by, sum, avg)? */ | ||
| aggregation: z.boolean().default(false), | ||
| /** Is scheme-less (needs schema inference)? */ | ||
| dynamicSchema: z.boolean().default(false), | ||
|
|
||
| /** Is read-only? */ | ||
| readOnly: z.boolean().default(false), | ||
|
|
||
| /** Is scheme-less (needs schema inference)? */ | ||
| dynamicSchema: z.boolean().default(false), | ||
| }); | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the
aggregationcapability field and its replacement withqueryAggregationsis a breaking change. While this rename provides better clarity and consistency with the new query capability naming scheme, any existing code that referencescapabilities.aggregationwill break.Consider: