Skip to content

Add missing view storage schemas to protocol.zod.ts#465

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/fix-issue-in-action-run-again
Closed

Add missing view storage schemas to protocol.zod.ts#465
Copilot wants to merge 3 commits intomainfrom
copilot/fix-issue-in-action-run-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 1, 2026

Test suite was importing GetViewRequestSchema, DeleteViewRequestSchema, and DeleteViewResponseSchema from protocol.zod.ts, but these exports were undefined.

Changes

packages/spec/src/api/protocol.zod.ts

  • Added View Storage Operations section with 3 missing schemas:
    • GetViewRequestSchema - retrieve stored view by ID
    • DeleteViewRequestSchema - delete stored view by ID
    • DeleteViewResponseSchema - deletion result
  • Exported corresponding TypeScript types via z.infer<>

Generated artifacts

  • JSON schemas in packages/spec/json-schema/api/
  • Documentation updated in content/docs/references/api/protocol.mdx
// View Storage Operations
export const GetViewRequestSchema = z.object({
  id: z.string().describe('View ID'),
});

export const DeleteViewRequestSchema = z.object({
  id: z.string().describe('View ID to delete'),
});

export const DeleteViewResponseSchema = z.object({
  success: z.boolean().describe('Whether deletion succeeded'),
});

Follows existing protocol schema patterns. All schemas use camelCase for configuration keys per repository conventions.

Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21566161109/job/62137890954#step:8:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Feb 1, 2026 4:48pm

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue in action run identified by job 62137890954 Add missing view storage schemas to protocol.zod.ts Feb 1, 2026
Copilot AI requested a review from hotlong February 1, 2026 16:48
@github-actions github-actions bot added documentation Improvements or additions to documentation size/s labels Feb 1, 2026
@hotlong hotlong closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants