Skip to content

Clarify ObjectQL and Hono as canonical implementations of capability contracts#340

Closed
Copilot wants to merge 2 commits intocopilot/create-core-foundationfrom
copilot/update-data-engine-http
Closed

Clarify ObjectQL and Hono as canonical implementations of capability contracts#340
Copilot wants to merge 2 commits intocopilot/create-core-foundationfrom
copilot/update-data-engine-http

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 28, 2026

PR #339 introduced IHttpServer and IDataEngine interfaces but didn't establish which implementations are canonical for ObjectStack. Feedback specified: ObjectQL is the data engine, Hono is HTTP.

Changes

Interface documentation (data-engine.ts, http-server.ts)

  • Added primary implementation annotations identifying ObjectQL and Hono as canonical
  • Listed alternative implementations (Prisma/TypeORM, Express/Fastify)

README (packages/runtime/README.md)

  • Updated API reference to specify primary implementations
  • Reordered examples to show canonical implementations first

Test fixtures (test-interfaces.ts)

  • Added header clarifying ObjectQL/Hono are production implementations
  • Noted mocks are for interface contract testing only
/**
 * IDataEngine - Standard Data Engine Interface
 * 
 * **Primary Implementation:** ObjectQL (@objectstack/objectql)
 * - ObjectQL is the canonical data engine for ObjectStack
 * - Provides metadata-driven CRUD operations with driver abstraction
 * 
 * **Alternative Implementations:** Prisma, TypeORM, Mongoose, etc.
 */
export interface IDataEngine { ... }

Documentation-only changes. Dependency Inversion Principle maintained - interfaces remain abstract, alternatives still supported.

Original prompt

拉取请求: #339

@copilot objectql 就是 data engine hono 就是 http,


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
spec Ready Ready Preview, Comment Jan 28, 2026 5:30am

Request Review

… as primary implementations

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update data engine and HTTP integration Clarify ObjectQL and Hono as canonical implementations of capability contracts Jan 28, 2026
Copilot AI requested a review from hotlong January 28, 2026 05:30
@hotlong hotlong closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants