Skip to content

Conversation

@sumitsharansatsangi
Copy link

@Mairramer
Copy link

Could you avoid running the formatter in this PR? This should be done later in a separate PR, applied only to the essential files. Including it here makes the review harder.

@sumitsharansatsangi
Copy link
Author

@Mairramer , Could you review it now?

@greenrobot-team
Copy link
Member

Resolved by #752 and #751 instead. So sorry, closing.

As I said, please talk to us before proposing larger changes (also for license reasons)!

I had a quick look regardless and I likely would not have accepted this anyway as this mixes various unrelated changes in just two commits (and to be argued in a single pull request).

Also note that @Mairramer is not a maintainer of this project. You can see that I am by the "Member" tag in my comments or when hovering over my user name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants