feat: update api #148
Merged
feat: update api #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generated Strava API client code by regenerating it from the OpenAPI specification. The changes include modernized Go patterns, improved error handling, and API schema updates.
Key changes:
- Replace deprecated type assertion patterns with
errors.As()for better error handling - Update
interface{}toany(Go 1.18+ idiomatic type) - Replace
err != io.EOFwith!stderrors.Is(err, io.EOF)for proper error comparison - Add new
DeviceNamefield to activity models
Reviewed Changes
Copilot reviewed 127 out of 127 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/gen/strava-api-go/models/*.go | Updated model validation to use errors.As(), replaced interface{} with any, removed extra blank lines |
| internal/gen/strava-api-go/client//.go | Updated client methods with improved error handling patterns, modernized type usage, and better comments |
| internal/gen/strava-api-go/models/detailed_activity.go | Added new DeviceName field to activity models with proper marshaling/unmarshaling |
| internal/gen/strava-api-go/models/summary_activity.go | Added new DeviceName field to summary activity models |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.