Skip to content

CI: Remove daily benchmarks pipeline#6482

Merged
martintomazic merged 1 commit intomasterfrom
martin/trivial/disable-metrics-collection
Apr 16, 2026
Merged

CI: Remove daily benchmarks pipeline#6482
martintomazic merged 1 commit intomasterfrom
martin/trivial/disable-metrics-collection

Conversation

@martintomazic
Copy link
Copy Markdown
Contributor

@martintomazic martintomazic commented Mar 25, 2026

Closes #6486.

Daily benchmark have been failing for a while: https://buildkite.com/oasisprotocol

They weren't used for 1 year+, neither are metrics and their regression from light e2e tests representative therefore we can safely remove them.

Lets open a new issue instead for creating a new pipeline that triggers on the new oasis-core release and starts a representative load (e.g. sync from latest checkpoint or few months back in time) and check performance regression + store relevant artifacts long time.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 25, 2026

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit c45a76b
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69e09beab6cb0b00085f67b1

@martintomazic martintomazic force-pushed the martin/trivial/disable-metrics-collection branch from 8c852e7 to 5380a5e Compare March 25, 2026 11:59
Comment thread .buildkite/benchmarks.pipeline.yml Outdated
Comment thread .buildkite/benchmarks.pipeline.yml Outdated
@martintomazic
Copy link
Copy Markdown
Contributor Author

Long test seems to work:

Daily benchmarks seems to be stuck at reading non-existing stuff, likely a config/pipeline issue (exploring):

@martintomazic martintomazic changed the title CI: Disable pushing to non-existent push gateway during e2e test CI: Fix daily benchmarks pipeline Mar 26, 2026
@martintomazic martintomazic force-pushed the martin/trivial/disable-metrics-collection branch from 0a5f1f6 to d8be672 Compare April 15, 2026 12:08
@martintomazic
Copy link
Copy Markdown
Contributor Author

Once merged also Archive Pipeline in the buildkite UI?

@martintomazic martintomazic marked this pull request as ready for review April 15, 2026 12:51
@martintomazic martintomazic changed the title CI: Fix daily benchmarks pipeline CI: Remove daily benchmarks pipeline Apr 15, 2026
@martintomazic martintomazic force-pushed the martin/trivial/disable-metrics-collection branch from d8be672 to c45a76b Compare April 16, 2026 08:20
Copy link
Copy Markdown
Collaborator

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add internal changelog, so that it is easier to find these changes and the removed code.

@martintomazic
Copy link
Copy Markdown
Contributor Author

I would add internal changelog, so that it is easier to find these changes and the removed code.

I see your point, but looking at changelog descriptions, the intended audience are not people working on the code itself so CI changes should not be part of it.

Opened an issue to track this: #6503.

If you are fine I will merge as is?

@peternose
Copy link
Copy Markdown
Collaborator

I would add internal changelog, so that it is easier to find these changes and the removed code.

I see your point, but looking at changelog descriptions, the intended audience are not people working on the code itself so CI changes should not be part of it.

Opened an issue to track this: #6503.

If you are fine I will merge as is?

Internal is still for us, I think. Yes, you can merge.

@martintomazic martintomazic merged commit e650c8e into master Apr 16, 2026
5 checks passed
@martintomazic martintomazic deleted the martin/trivial/disable-metrics-collection branch April 16, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing daily benchmarks pipeline

3 participants