CI: Remove daily benchmarks pipeline#6482
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
8c852e7 to
5380a5e
Compare
|
Long test seems to work: Daily benchmarks seems to be stuck at reading non-existing stuff, likely a config/pipeline issue (exploring): |
0a5f1f6 to
d8be672
Compare
|
Once merged also |
d8be672 to
c45a76b
Compare
peternose
left a comment
There was a problem hiding this comment.
I would add internal changelog, so that it is easier to find these changes and the removed code.
I see your point, but looking at changelog descriptions, the intended audience are not people working on the code itself so CI changes should not be part of it. Opened an issue to track this: #6503. If you are fine I will merge as is? |
Internal is still for us, I think. Yes, you can merge. |
Closes #6486.
Daily benchmark have been failing for a while: https://buildkite.com/oasisprotocol
They weren't used for 1 year+, neither are metrics and their regression from light e2e tests representative therefore we can safely remove them.
Lets open a new issue instead for creating a new pipeline that triggers on the new oasis-core release and starts a representative load (e.g. sync from latest checkpoint or few months back in time) and check performance regression + store relevant artifacts long time.