feat: enhance address formatting in staking transactions#683
Open
uniyalabhishek wants to merge 1 commit intomasterfrom
Open
feat: enhance address formatting in staking transactions#683uniyalabhishek wants to merge 1 commit intomasterfrom
uniyalabhishek wants to merge 1 commit intomasterfrom
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
matevz
reviewed
Feb 5, 2026
Member
matevz
left a comment
There was a problem hiding this comment.
This seems very hacky. Account names should be added to the pretty printing code in oasis-core, for example
https://github.com/oasisprotocol/oasis-core/blob/master/go/oasis-node/cmd/stake/allowances.go#L90
Other consensus transactions like staking.Transfer for transferring ROSE should also use named accounts then. No need to support the newly added ethMap in ctx though, because those cannot sign consensus transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @matevz in Slack: there is one more transaction that needs love, e.g.
Beneficiary above should be
paratime:sapphire (oasis1...)