Skip to content

feat: enhance address formatting in staking transactions#683

Open
uniyalabhishek wants to merge 1 commit intomasterfrom
uniyalabhishek/cmd/staking-txns-address-fmt
Open

feat: enhance address formatting in staking transactions#683
uniyalabhishek wants to merge 1 commit intomasterfrom
uniyalabhishek/cmd/staking-txns-address-fmt

Conversation

@uniyalabhishek
Copy link
Contributor

@uniyalabhishek uniyalabhishek commented Feb 5, 2026

From @matevz in Slack: there is one more transaction that needs love, e.g.

$ oasis acc allow paratime:sapphire 10 --account test:alice
You are about to sign the following transaction:
Method: staking.Allow
Body:
  Beneficiary:   oasis1qqczuf3x6glkgjuf0xgtcpjjw95r3crf7y2323xd
  Amount change: +10.0 TEST
Nonce:  54
Fee:
  Amount: 0.0 TEST
  Gas limit: 1286
  (gas price: 0.0 TEST per gas unit)

Network:  testnet
ParaTime: none (consensus layer)
Account:  test:alice

Beneficiary above should be paratime:sapphire (oasis1...)

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 8d27736
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/69844b958f7c230008499075

@uniyalabhishek uniyalabhishek requested a review from matevz February 5, 2026 07:56
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very hacky. Account names should be added to the pretty printing code in oasis-core, for example
https://github.com/oasisprotocol/oasis-core/blob/master/go/oasis-node/cmd/stake/allowances.go#L90

Other consensus transactions like staking.Transfer for transferring ROSE should also use named accounts then. No need to support the newly added ethMap in ctx though, because those cannot sign consensus transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants