Skip to content

fix: update icons for yaml/yml extensions#629

Merged
alex-courtis merged 2 commits intonvim-tree:masterfrom
fjfnaranjo:patch-2
Apr 9, 2026
Merged

fix: update icons for yaml/yml extensions#629
alex-courtis merged 2 commits intonvim-tree:masterfrom
fjfnaranjo:patch-2

Conversation

@fjfnaranjo
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please:

Should we consider changing the colour to #cc1018 as per https://yaml.org/assets/logo.png

@fjfnaranjo
Copy link
Copy Markdown
Contributor Author

fjfnaranjo commented Apr 8, 2026

Thanks for the feedback @alex-courtis!

I didn't realize there was another file for light bgs :(

I considered changing the color in the initial commit, but they use a red that is very close to pure RGB red. They do the same for secondary colors in the website so I just left it with the grey that was used for other configuration formats.

But I reviewed it carefully and I went with cterm Red3, instead of Red1. Is less saturated and should render ok.

What do you think?

imagen imagen

@fjfnaranjo fjfnaranjo requested a review from alex-courtis April 8, 2026 12:56
@alex-courtis
Copy link
Copy Markdown
Member

But I reviewed it carefully and I went with cterm Red3, instead of Red1. Is less saturated and should render ok.

Looks good, blends in with others and won't stand out too much.

Copy link
Copy Markdown
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a build failure - the cterm icons are being overwritten.

We need to go the other way - set the color and cterm_color will be updated in all places when you build.

I've updated the instructions for more clarity: https://github.com/nvim-tree/nvim-web-devicons?tab=contributing-ov-file#adding-or-updating-icons

@fjfnaranjo
Copy link
Copy Markdown
Contributor Author

Oh. I see. Thanks!

I guessed the "light" icons was a file intended to supply an alternative design/color for non-dark backgrounds. Looks like its completely automated and uses the values from the other file (I didn't see the comment in the top of the file).

Also, I wasn't running the make targets, I was editing directly. I guess that is the main issue for my PRs failing in the CI. The "building" is like a "pre-push" requirement, as if it was a regular program.

What I was doing is using my local Neovim install to verify it worked correctly.

I will prepare a container to build it and send a new commit when it does without failures.

@fjfnaranjo
Copy link
Copy Markdown
Contributor Author

fjfnaranjo commented Apr 9, 2026

I did the make this time, having modified only the "default" file.

I'm leaving here a Debian 13 based container definition to run make.

#632

Copy link
Copy Markdown
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

@alex-courtis alex-courtis merged commit c72328a into nvim-tree:master Apr 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants