fix: update icons for yaml/yml extensions#629
Conversation
There was a problem hiding this comment.
Thank you for your contribution!
Please:
- Update the light icon colours etc as per CONTRIBUTING.md
Should we consider changing the colour to #cc1018 as per https://yaml.org/assets/logo.png
|
Thanks for the feedback @alex-courtis! I didn't realize there was another file for light bgs :( I considered changing the color in the initial commit, but they use a red that is very close to pure RGB red. They do the same for secondary colors in the website so I just left it with the grey that was used for other configuration formats. But I reviewed it carefully and I went with cterm Red3, instead of Red1. Is less saturated and should render ok. What do you think?
|
Looks good, blends in with others and won't stand out too much. |
alex-courtis
left a comment
There was a problem hiding this comment.
We have a build failure - the cterm icons are being overwritten.
We need to go the other way - set the color and cterm_color will be updated in all places when you build.
I've updated the instructions for more clarity: https://github.com/nvim-tree/nvim-web-devicons?tab=contributing-ov-file#adding-or-updating-icons
|
Oh. I see. Thanks! I guessed the "light" icons was a file intended to supply an alternative design/color for non-dark backgrounds. Looks like its completely automated and uses the values from the other file (I didn't see the comment in the top of the file). Also, I wasn't running the make targets, I was editing directly. I guess that is the main issue for my PRs failing in the CI. The "building" is like a "pre-push" requirement, as if it was a regular program. What I was doing is using my local Neovim install to verify it worked correctly. I will prepare a container to build it and send a new commit when it does without failures. |
|
I did the I'm leaving here a Debian 13 based container definition to run |
alex-courtis
left a comment
There was a problem hiding this comment.
Many thanks for your contribution!


No description provided.