fix: incorrect window width when right_align icons present

[simonmandlik]

This PR fixes a bug introduced in #3214

In grow() when M.View.root_excluded is true lines starts from the second line, but later in the for loop we index starting from 1 always.

[alex-courtis]

Thanks for looking after this one @simonmandlik

This looks right, however I cannot identify the bug. Can you please decscribe how to reproduce it so that I can test?

[simonmandlik]

There are several ingredients needed:

• use right-aligned icons
• use the root for width computation
• have an icon shown on the widest item

Before the fix:

With the fix:

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvt-min/site]])
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing nvim-tree and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]])
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup({
    view = {
      width = {
        min = 0,
        padding = 0,
        lines_excluded = {},
      }
    },
    renderer = {
      icons = {
        git_placement = "right_align",
      }
    }
  })
end

[alex-courtis]

Tested OK, love your work as always @simonmandlik