test(keymap): react to Nightly changes regarding autoindent#2428
Merged
Conversation
Member
|
Thanks for the PR!
Mostly because it requires extra key translation to be useful. And that sequence of keys is exactly what 'nvim-autopairs' uses. As the matter of fact, the 'nvim-autopairs' plugin itself now acts on Nightly exactly as is detected by 'mini.keymap' test. It might be the problem in either vim-patch or 'nvim-autopairs'. Don't really have the bandwidth to investigate this (although it would probably be a net positive for Neovim ecosystem :) ). |
echasnovski
reviewed
May 23, 2026
Details: - See PR 39961 in neovim/neovim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
I wasn't able to fix this properly. The test now passes because I disabled
autoindent, allowing the third line to be empty.I wonder why the
nvim-autopairsmock is more specific than the other mocks, which mostly add a line to the_G.log. Is the comment stating-- Mock exactly how 'nvim-autopairs' works herestill applicable? Perhaps a simple_G.logaddition is enough.The failing test:
EDIT:
I think this issue can also be closed...
EDIT2:
It's strange that the third empty line is now subject to truncation. Maybe the vim-patch is not selective enough?