test(ALL): fix tests that fail when using git worktree#2310
test(ALL): fix tests that fail when using git worktree#2310echasnovski merged 1 commit intonvim-mini:mainfrom
Conversation
|
Could you please elaborate on what is the problem here? How can I reproduce the test fails? All tests (implicitly) assume that they are run from inside the project's root directory. Usually it is called 'mini.nvim', but with Git worktrees it can have another name and that is the problem, right? If yes, then no repro steps needed. Just please make sure that after this PR all tests pass in this scenario (preferably on all supported Neovim versions, but that should be okay if works on latest release). Please:
Also, I am not convinced that changing a directory to something that doesn't exist is a good idea. Could you please find another (concise) way to make 'mini.tabline' test pass in this case? |
Yes, that's the problem. I have 'mini.nvim' in the 'projects/plugin' folder, alongside 'mini_fix_x' and 'mini_test_fix_x' |
cce0925 to
2b164a4
Compare
|
I pushed a new version
I don't understand unfortunately. The directory in |
Sorry, I missed that this PR adds the new directory. I was confused that there is a I think this is better be solved by increasing |
2b164a4 to
2eb1b00
Compare
Much better indeed. Done! |
Details: - When using git worktree, the mini.nvim repository is also checked-out under a different name. That causes some tests to fail. - test_tabline: The tabline in test 'deduplicates named labels' changes when the cwd is not 'mini.nvim'. Solution: increase child.o.columns. - test_snippets: The screenshot in 'Session persists after :edit' assumes that the name of the repro is mini.nvim. Solution: use a dummy statusline.
2eb1b00 to
045f228
Compare
echasnovski
left a comment
There was a problem hiding this comment.
As it is now, looks good to me.
@abeldekat, did you make sure that this is all the tests that need adjustment to work with this "Git worktree" workflow?
Yes. I also grepped the screenshots searching for |
Details(editted):
When using git worktree, the mini.nvim repository is also checked-out under a different name. That causes some tests to fail.
test_tabline: The tabline in test 'deduplicates named labels' changes when the cwd is not 'mini.nvim'. Solution: increase child.o.columns
test_snippets: The screenshot in 'Session persists after :edit' assumes that the name of the repro is mini.nvim. Solution: use a dummy statusline.