Run workflow just when files are changed in the addon folder#21
Run workflow just when files are changed in the addon folder#21seanbudd merged 2 commits intonvaccess:masterfrom
Conversation
|
@seanbudd , I think that this is ready for review. |
|
@nvdaes, just discovering this PR. Why this restriction to addon folder? Which issue was this addressing?
So the best solution IMO is to just remove this restriction. If you really need a restriction for a specific reason, that I do not know, I'd recommend to filter the other way around, i.e. excluding paths as follows. E.g.: |
|
Cyrille wrote:
@seanbudd requested this and I thought that it was a good idea to avoid checks to be run, for example, when changing files like gitignore, other ones included in the github folder, and I thought that following the addonTemplate the sconstruct and other files shouldn't affect the way add-ons would be created, but I also thought about using the paths ignore filter. I think that the addons folder is the most obvious thing that can change which requires checks, and I decided to use the paths filter. But you may be right, and in this case perhaps the best solution is to revert this PR, since it's difficult to know what could affect the builting of an addon bundle. Even the github folder may affect if someone uses GitHub Actions to download a package and then build the add-on. |
|
Yes, I support reverting the restriction part of this PR; making hypothesis on which file would impact the bundle or not is too fragile IMO. The Just in case, had this restriction request from Sean been discussed somewhere (publicly)? Thanks. |
Currently, checks are run with GitHub Actions regardless of files which have been changed.
This PR makes checks to be run just for add-ons. Additionally, Python and dependencies are installed using uv and pyproject.toml.