Skip to content

Run workflow just when files are changed in the addon folder#21

Merged
seanbudd merged 2 commits intonvaccess:masterfrom
nvdaes:fixBui9ld
Mar 3, 2026
Merged

Run workflow just when files are changed in the addon folder#21
seanbudd merged 2 commits intonvaccess:masterfrom
nvdaes:fixBui9ld

Conversation

@nvdaes
Copy link

@nvdaes nvdaes commented Mar 3, 2026

  • Check code just for add-ons
  • Remove folder
  • ### Description

Currently, checks are run with GitHub Actions regardless of files which have been changed.

This PR makes checks to be run just for add-ons. Additionally, Python and dependencies are installed using uv and pyproject.toml.

@nvdaes
Copy link
Author

nvdaes commented Mar 3, 2026

@seanbudd , I think that this is ready for review.

@seanbudd seanbudd merged commit 3ab0021 into nvaccess:master Mar 3, 2026
1 check passed
@CyrilleB79
Copy link

@nvdaes, just discovering this PR.

Why this restriction to addon folder? Which issue was this addressing?
The builds for add-ons are quite short so I do not understand why you need to restrict them.
Moreover, modifying files outside the addon folder may have an impact on the generated .addon file:

  • some files are copied in the bundle (readme.md, style.css)
  • some files control its content, e.g. buildVars.py controls the bundled manifest file, sconstruct modification can have any effect, including on what is in the bundle, etc.

So the best solution IMO is to just remove this restriction.

If you really need a restriction for a specific reason, that I do not know, I'd recommend to filter the other way around, i.e. excluding paths as follows. E.g.:

  pull_request:
    branches: [ main, master ]
    paths-ignore:
    - .github/**

@nvdaes
Copy link
Author

nvdaes commented Mar 3, 2026

Cyrille wrote:

Why this restriction to addon folder? Which issue was this addressing?

@seanbudd requested this and I thought that it was a good idea to avoid checks to be run, for example, when changing files like gitignore, other ones included in the github folder, and I thought that following the addonTemplate the sconstruct and other files shouldn't affect the way add-ons would be created, but I also thought about using the paths ignore filter. I think that the addons folder is the most obvious thing that can change which requires checks, and I decided to use the paths filter. But you may be right, and in this case perhaps the best solution is to revert this PR, since it's difficult to know what could affect the builting of an addon bundle. Even the github folder may affect if someone uses GitHub Actions to download a package and then build the add-on.
@seanbudd what do you think?

@CyrilleB79
Copy link

Yes, I support reverting the restriction part of this PR; making hypothesis on which file would impact the bundle or not is too fragile IMO.

The uv part can remain.

Just in case, had this restriction request from Sean been discussed somewhere (publicly)? Thanks.

@CyrilleB79
Copy link

OK. I have just opened #22 to remove this restriction. Let's see what @seanbudd thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants