Skip to content

fix(InputDate/InputTime): increase segments width#6339

Merged
benjamincanac merged 5 commits intonuxt:v4from
mikenewbon:fix/input-date-month-width
Apr 17, 2026
Merged

fix(InputDate/InputTime): increase segments width#6339
benjamincanac merged 5 commits intonuxt:v4from
mikenewbon:fix/input-date-month-width

Conversation

@mikenewbon
Copy link
Copy Markdown
Contributor

@mikenewbon mikenewbon commented Apr 12, 2026

🔗 Linked issue

Resolves #6338

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Initially I thought it was just xs/sm that was broken as they split onto two lines on mobile but in all sizes it was squashed.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Apr 12, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026

📝 Walkthrough

Walkthrough

Adjusted Tailwind width utilities for segment slots in two theme files. In src/theme/input-date.ts the size variants update data-[segment=day], data-[segment=month], and data-[segment=year] widths (increasing w-* values across xs, sm, md, lg, xl). In src/theme/input-time.ts the size variants update the segment slot width when data-[segment=literal] is present (increasing w-* values for xs, sm, md, lg, xl). No other variant keys, slot definitions, or exported/public declarations were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining that the width classes were increased to fix the month segment being squashed and splitting onto two lines on mobile viewports.
Linked Issues check ✅ Passed The changes successfully address issue #6338 by increasing Tailwind width classes for date/time segments across all sizes (xs, sm, md, lg, xl), fixing the squashing and line-break issues reported on mobile.
Out of Scope Changes check ✅ Passed All changes are directly scoped to updating Tailwind width utility classes in InputDate and InputTime components to resolve the reported layout issue; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main changes: width adjustments for both InputDate and InputTime segment components across all size variants.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 12, 2026

npm i https://pkg.pr.new/@nuxt/ui@6339

commit: 94c0e48

Copy link
Copy Markdown
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikenewbon I think we should increase day and month by one so they look identical, wdyt?

@mikenewbon
Copy link
Copy Markdown
Contributor Author

mikenewbon commented Apr 16, 2026

@benjamincanac lgtm, pushed! (Feel free to change if I misunderstood)

@benjamincanac benjamincanac changed the title fix(InputDate): update width classes for month segment in date input component fix(InputDate/InputTime): increase segment width classes for consistency Apr 17, 2026
@benjamincanac benjamincanac changed the title fix(InputDate/InputTime): increase segment width classes for consistency fix(InputDate/InputTime): increase segment width classes Apr 17, 2026
@benjamincanac benjamincanac changed the title fix(InputDate/InputTime): increase segment width classes fix(InputDate/InputTime): increase segments width Apr 17, 2026
@benjamincanac benjamincanac merged commit 4ebdb2f into nuxt:v4 Apr 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InputDate month breaks on mobile for sm/xs

2 participants