feat(runtime): export Picture and Image props types#2115
Conversation
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded two public type exports in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
would you take a look at the failing tests? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/runtime/types.ts`:
- Around line 1-2: Remove the leading blank line at the top of the types file
and ensure the file ends with a single trailing newline to satisfy ESLint rules;
update the declaration for the DataAttributes type (export type DataAttributes =
Record<`data-${string}`, string>) so there is no blank line before it and the
file terminates with a newline character.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
=======================================
Coverage 32.52% 32.52%
=======================================
Files 7 7
Lines 372 372
Branches 131 131
=======================================
Hits 121 121
Misses 194 194
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying nuxt-image with
|
| Latest commit: |
766e179
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7141f96f.nuxt-image.pages.dev |
| Branch Preview URL: | https://feat-export-props-types.nuxt-image.pages.dev |
🔗 Linked issue
❓ Type of change
📚 Description
this PR exports ImageProps and PictureProps in
@nuxt/image/runtime