Skip to content

Conversation

@prudhomm
Copy link
Collaborator

@prudhomm prudhomm commented Mar 31, 2025

@prudhomm prudhomm added the enhancement New feature or request label Mar 31, 2025
@prudhomm prudhomm requested review from abuttari and Copilot March 31, 2025 22:58
@prudhomm prudhomm self-assigned this Mar 31, 2025
@prudhomm prudhomm linked an issue Mar 31, 2025 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

LGTM! 🚀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a devcontainer setup and updates CI workflows to include linting and LaTeX poster compilation while closing issue #4.

  • Added a lint GitHub Actions workflow for code quality checks.
  • Updated the LaTeX workflow to compile and manage poster artifacts.
  • Introduced a new devcontainer configuration for LaTeX development.

Reviewed Changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/lint.yml New workflow to run linting checks using chktex-action.
.github/workflows/latex.yml Adds steps for poster compilation and updates artifact naming.
.devcontainer/docker-compose.yml Provides a devcontainer configuration for LaTeX development.
Files not reviewed (4)
  • .devcontainer/Dockerfile: Language not supported
  • .devcontainer/devcontainer.json: Language not supported
  • .vscode/settings.json: Language not supported
  • poster.template.tex: Language not supported
Comments suppressed due to low confidence (1)

.devcontainer/docker-compose.yml:4

  • [nitpick] The service name 'vscode' is ambiguous given the container is used for LaTeX development. Consider renaming it to a name that reflects its purpose more clearly.
  vscode:

# Shell history persistence
- ~/.zsh_history:/root/.zsh_history:z
environment:
- TZ=
Copy link

Copilot AI Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable 'TZ' is set to an empty value, which might lead to unexpected timezone behavior. Provide a valid timezone or remove the variable if it's not needed.

Suggested change
- TZ=

Copilot uses AI. Check for mistakes.
@prudhomm prudhomm changed the title resolves 4: add support for devcontainer resolves 4 and 5: add support for devcontainer and add poster template Mar 31, 2025
@abuttari
Copy link
Collaborator

abuttari commented Apr 1, 2025

great work @prudhomm !
the logos on the bottom of the poster will be smaller than 1cm when printed on an actual A0 sheet. Is this intended or should they be a bit bigger?

@prudhomm
Copy link
Collaborator Author

prudhomm commented Apr 1, 2025

The design is not quite finished yet. We should probably put a footline: a qr code at the bottom and space for extra information. What do you think?

@abuttari
Copy link
Collaborator

abuttari commented Apr 1, 2025

The design is not quite finished yet. We should probably put a footline: a qr code at the bottom and space for extra information. What do you think?

Sure, good idea

…e with new features and styling

add footline in poster

add poster template #5
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

… templates for improved SVG support and font settings

add support for devcontainer #4
add poster template #5 (add inkscape)
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

Copy link
Collaborator

@abuttari abuttari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@abuttari abuttari merged commit af0fd50 into main Apr 3, 2025
4 checks passed
@prudhomm prudhomm deleted the 4-add-support-for-devcontainer branch April 3, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add poster template add support for devcontainer

3 participants