Open
Conversation
Before this commit, FTerm always returned to the last window even though
it might not be on the same tabpage. This commit fixes this behavior and
switches only to the last window if its on the current tabpage.
Reproduce the issue:
- Open nvim
- Start a new terminal with `lua require("FTerm").open()`
- Switch to another tabpage / open a new one
- Close the terminal window with `lua require("FTerm").close()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, FTerm always returned to the last window even though it might not be on the same tabpage. This commit fixes this behavior and switches only to the last window if its on the current tabpage.
Reproduce the issue:
lua require("FTerm").open()lua require("FTerm").close()Thanks a lot for your work on this plugin! :)