Default to a love-supported bit depth for SoundData#20
Open
idbrii wants to merge 1 commit intonucular:masterfrom
Open
Default to a love-supported bit depth for SoundData#20idbrii wants to merge 1 commit intonucular:masterfrom
idbrii wants to merge 1 commit intonucular:masterfrom
Conversation
Fix "Invalid bit depth: 0" error in love when calling generateSoundData without arguments. Love2d 11 (and earlier?) only supports 8 and 16, so don't default to 0 when generating a love object.
|
Well, this is not right. Without it, LÖVE won't be able to create SoundData: "Invalid bit depth: 0", but with it the resulting SoundData won't be correct: PCM samples are stored as either 8 or 16 bit signed integers, but are set as floats. So we need this 0 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "Invalid bit depth: 0" error in love when calling generateSoundData
without arguments.
love.sound.newSoundData in Love2d 11 (and earlier?) only supports 8 and 16, so don't default to 0
when generating a love object.