Open
Conversation
…bably a longstanding bug brought to the fore by the fact that loveframes now crashes if the choice value is nil
…ual to the expected version.
…that it was created/exists
|
Thanks for your work on this PR! sfxr is pretty useful and it's nice to have a working UI. Edit: Nevermind. If you run
package.path = package.path .. ";../?.lua"
|
|
One change missed in this update was using the supported version of getDirectoryItems. The callback is no longer supported so the save/load dialogs never showed any files. Fix: idbrii@0da9d70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset contains two categories of fixes:
For (1) the changes:
a. update to the 11.x fork of LoveFrames that is being maintained by @linux-man
b. change any color literals to use components in the range (0,1) instead of (0,255)
c. move usage of deprecated
love.filesystemfunctions to current versions.d. fix a field name that was probably incorrect for a long time but now causes an assertion failure in LoveFrames.
e. reflect changes to LoveFrames skin API
For (2) the changes:
a. Make the version check not fail if the expected version == the found version when loading a lua file.
b. Replace references to globals
freqandbitsthat are not defined insfxr.luain the wav export code with localsrateanddepth.