Skip to content

feat: migrate document link to language-service#94

Merged
9romise merged 2 commits intomainfrom
document-link
Apr 1, 2026
Merged

feat: migrate document link to language-service#94
9romise merged 2 commits intomainfrom
document-link

Conversation

@9romise
Copy link
Copy Markdown
Member

@9romise 9romise commented Mar 31, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4cb9bb3e-f153-42dc-82c4-21c67a682804

📥 Commits

Reviewing files that changed from the base of the PR and between e3a9a92 and f70ef79.

📒 Files selected for processing (5)
  • extensions/vscode/src/index.ts
  • extensions/vscode/src/providers/document-link/index.ts
  • extensions/vscode/src/providers/document-link/npmx.ts
  • packages/language-service/src/index.ts
  • packages/language-service/src/plugins/document-link.ts
💤 Files with no reviewable changes (3)
  • extensions/vscode/src/index.ts
  • extensions/vscode/src/providers/document-link/index.ts
  • extensions/vscode/src/providers/document-link/npmx.ts

📝 Walkthrough

Walkthrough

This change migrates the document link provider from a VS Code extension-side implementation to a language service plugin architecture. The useDocumentLink provider and NpmxDocumentLinkProvider class were removed from the extension, whilst a new npmx-document-link language service plugin was added to provide equivalent functionality. The plugin reads package link configuration, identifies dependencies in compatible files, and generates document links to npmx package URLs based on the configured mode (declared or resolved versions).

Possibly related PRs

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, making it impossible to assess whether any explanation was intended. Add a pull request description explaining the rationale, changes, and benefits of migrating the document link functionality to the language-service package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch document-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9romise 9romise added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 09032ff Apr 1, 2026
11 checks passed
@9romise 9romise deleted the document-link branch April 1, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant