refactor: remove dead parse() code from git provider adapters#2761
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughuseRepoMeta now parses repository URLs with parseRepoUrl and selects provider adapters via a keyed providers Record. ProviderAdapter no longer requires id/parse; adapters only provide links(ref) and fetchMeta(...). The registry changed from an ordered array to a Record<ProviderId, ProviderAdapter> and missing adapters return null. ChangesuseRepoMeta provider adapter refactoring
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3ef3ef1 to
2c063eb
Compare
This was refactored at some point long ago to use a shared `parseRepoUrl` but the old unused `parse` methods were orphaned.
2c063eb to
99af280
Compare
🔗 Linked issue
N/A
🧭 Context
This was refactored at some point long ago to use a shared
parseRepoUrlbut the old unusedparsemethods were orphaned.📚 Description
Remove the dead code!