feat: update governance list and design#2756
Open
alexdln wants to merge 6 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a 'core' contributor role and backend handling; extracts governance rendering into a new GovernanceList component; refactors about.vue to group governance (steward+core), maintainers, and contributors; harmonises avatar/logo styling; updates i18n/schema; and adds accessibility tests for the new component. ChangesGovernance Role and Component Extraction
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/About/GovernanceList.vue`:
- Around line 8-14: The roleLabels computed property is missing a translated
label for the "core" Role, causing it to fall back to raw text; update the
object inside the roleLabels computed (the mapping that currently contains
steward and maintainer) to include core: $t('about.team.role_core'), and also
add the key about.team.role_core to your locale files and schema so the
translation is available for all locales.
In `@server/api/contributors.get.ts`:
- Around line 114-117: The role rank values are inverted relative to the
ascending final sort; update the numeric orders returned in the role-resolution
block so higher-precedence roles get smaller numbers for an ascending sort
(e.g., change teams.steward -> order: 0, teams.core -> order: 1,
teams.maintainer -> order: 2, and default contributor -> order: 3) by editing
the return objects in the function that resolves roles (the lines returning {
role: 'steward', order: ... }, { role: 'core', order: ... }, { role:
'maintainer', order: ... }, and the final default).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0ce381e3-6ef4-4678-ba0d-cb1d46aaf3be
📒 Files selected for processing (8)
app/components/About/GovernanceList.vueapp/components/About/LogoList.vueapp/pages/about.vueapp/pages/pds.vuei18n/locales/en.jsoni18n/schema.jsonserver/api/contributors.get.tstest/nuxt/a11y.spec.ts
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
server/api/contributors.get.ts (1)
173-173: ⚡ Quick winUpdate stale role-group comment to match current filter logic.
Line 173 says “stewards + maintainers”, but Line 176 now includes
coreas well. Please update the comment to avoid future confusion when reading sponsor-eligibility logic.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/api/contributors.get.ts` at line 173, Update the stale inline comment that currently reads “stewards + maintainers” to accurately reflect the active filter logic by including the `core` group (e.g., “stewards, core, and maintainers”) near the sponsor-eligibility block in server/api/contributors.get.ts where the `core` group is now part of the filter; keep wording concise and aligned with the surrounding sponsor-eligibility logic so future readers aren’t confused.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@server/api/contributors.get.ts`:
- Line 173: Update the stale inline comment that currently reads “stewards +
maintainers” to accurately reflect the active filter logic by including the
`core` group (e.g., “stewards, core, and maintainers”) near the
sponsor-eligibility block in server/api/contributors.get.ts where the `core`
group is now part of the filter; keep wording concise and aligned with the
surrounding sponsor-eligibility logic so future readers aren’t confused.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e039c2d8-4049-4256-ac43-e54d961737c6
📒 Files selected for processing (4)
app/components/About/GovernanceList.vuei18n/locales/en.jsoni18n/schema.jsonserver/api/contributors.get.ts
✅ Files skipped from review due to trivial changes (1)
- i18n/locales/en.json
🚧 Files skipped from review as they are similar to previous changes (2)
- i18n/schema.json
- app/components/About/GovernanceList.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Since we added a separate core role, there are multiple roles in one group now. Divided it into two groups and updated the cards and contributors style to make everything more streamlined and neat
Screenshot