Skip to content

fix: prevent modal from taking full width on mobile screen#1067

Open
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:fix/prevent-modal-from-taking-full-width
Open

fix: prevent modal from taking full width on mobile screen#1067
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:fix/prevent-modal-from-taking-full-width

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 6, 2026

Currently in mobile screen, modal is taking full width. I think we can improve this.

Before:
modal-previous

After:
modal-now

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 3:23am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 3:23am
npmx-lunaria Ignored Ignored Feb 6, 2026 3:23am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the dialog element width in the Modal component file. The width class has been changed from w-full to w-[calc(100%-2rem)], which adjusts the horizontal spacing of the modal. This calculation reduces the overall width by 2 remote units whilst preserving all other component functionality and styling.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, describing a mobile modal width issue and providing before/after visual comparisons.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant