Update and rename OpenRails_by_wmuzeke.xml to Open Rails.xml#376
Update and rename OpenRails_by_wmuzeke.xml to Open Rails.xml#376wmuzeke wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
|
Currently, the JSON and the filename do all match. It's only with your piecewise flock of PRs that there was ever any mismatch. Please do all the changes you want, and make one PR. Your other three PR have been rejected, because piece-by-piece, none of them pass the checkers. You can just edit the file in the patch-2 branch to continue with this PR (or, if you are doing everything from the PR itself, just go to the "Files Changed" section, and edit the file from there in the website). Second, the idea behind this PR is flawed: the name
Note the "but also something else". That's why I added the author to the filename when I incorprotated your original submission, like is recommended in the CONTRIBUTING.md. Secondly, under that same requirement description, it says:
You used spaces in the original PR, which violates that rule. That's why I removed the space from the filename when I incorporated your original submission. So a PR that changes the filename (and associated JSON) from Please follow the rules and conventions set forth in CONTRIBUTING, or your submissions will continue to be rejected. |
|
Thanks for the explanation. I am new to using Github so I'm still learning how it works. I didn't realize you could do multiple changes on one pull request. I wasn't sure whether it was the JSON or the file name that needed updating to match. I now see the requirement that no spaces are allowed in the file name. Regards, David. |
Updated the file name to match the JSON information.