Improve gamedata validation#29
Merged
nosoop merged 1 commit intonosoop:masterfrom Oct 2, 2025
A1mDev:error_handling
Merged
Conversation
- Added stricter processing of game configuration data. - Previously, the extension often returned no errors, even if some sections were incorrect, giving a false sense of successful patch application. - Now, malformed sections or invalid entries trigger warnings or errors, making it clear when something is wrong. - This helps prevent silent failures and speeds up development and testing by alerting users to typos or misconfigurations in the patch data. - Fixed some type cast warnings. -Ensured proper initialization of MemoryPatchInfo fields, avoiding uninitialized offset values.
Owner
|
Thanks for the PR; looks fine enough to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incorrect, giving a false sense of successful patch application.
making it clear when something is wrong.
by alerting users to typos or misconfigurations in the patch data.