-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(search): align footer elements and add proper spacing #8571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
Hey @shayan0v0n did you try just moving the entire div that contains the powerdByLink, to the shortcutWrapper div? Seems that it works as well, maybe no need to create another class to it. |
|
Hello @paulobelucci, Actually, I need to keep the poweredByLink class because the alignment issue isn't just about horizontal spacing between sections—the text and logo inside the 'Powered by' link itself need specific vertical alignment. |
|
Ok. No problem. My bad, I thought the issue was just with the vertical alignment. 🙌🏼 |
|
Thanks @shayan0v0n for your first contribution 😎, nice work! |
|
Glad to hear that 🔥 , @aymen94 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8571 +/- ##
==========================================
+ Coverage 75.01% 75.02% +0.01%
==========================================
Files 103 103
Lines 9037 9037
Branches 311 311
==========================================
+ Hits 6779 6780 +1
+ Misses 2256 2255 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
araujogui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
araujogui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Fixed alignment and spacing issues in the search box footer component. The "to close" and "Powered by" sections were improperly aligned and lacked adequate spacing between them. This PR ensures visual consistency and proper layout across light and dark modes.
Changes made:
justify-centertojustify-betweenfor proper element distributionValidation
Before: The "to close" and "Powered by" sections were touching without proper spacing, and elements were not properly aligned.
After: Proper spacing between sections, all elements are visually aligned, and the footer layout is consistent.
Testing performed:
Screenshot of the fixed alignment:

before:
after:

Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.