Skip to content

Conversation

@canerakdas
Copy link
Member

Description

Follow up pr for #8561, adresses #8561 (comment)

@canerakdas canerakdas requested a review from a team as a code owner January 26, 2026 18:02
Copilot AI review requested due to automatic review settings January 26, 2026 18:02
@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Jan 26, 2026 6:03pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.01%. Comparing base (03f5ffc) to head (3f27d39).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8564      +/-   ##
==========================================
+ Coverage   74.96%   75.01%   +0.04%     
==========================================
  Files         103      103              
  Lines        9037     9037              
  Branches      312      311       -1     
==========================================
+ Hits         6775     6779       +4     
+ Misses       2260     2256       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the explicit circular prop from the Badge component and replaces it with automatic detection based on content length. When a Badge contains a single-character string, it automatically applies circular styling with monospace font.

Changes:

  • Removed the circular prop from Badge component's TypeScript interface
  • Implemented automatic circular badge detection for single-character strings
  • Updated Badge stories to remove explicit circular prop usage
  • Bumped package version from 1.5.7 to 1.5.8

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/ui-components/src/Common/Badge/index.tsx Removed circular prop and replaced with automatic detection logic based on string length
packages/ui-components/src/Common/Badge/index.stories.tsx Removed circular prop from story configurations while maintaining single-character examples
packages/ui-components/package.json Incremented package version for the change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovflowd
Copy link
Member

ovflowd commented Jan 27, 2026

Fast-tracking, cc @nodejs/nodejs-website

@ovflowd ovflowd added this pull request to the merge queue Jan 27, 2026
Merged via the queue into nodejs:main with commit 6003a64 Jan 27, 2026
19 checks passed
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants