Skip to content

[automated]: crowdin sync #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nodejs-crowdin wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −4
Open

[automated]: crowdin sync #8557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a243c0
chore: synced translations from crowdin
crowdin-bot Jan 30, 2026
040ea8a
chore: automated format of translated files
github-merge-queue[bot] Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/pages/id/about/partners.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dan pengembangan berkelanjutan dari Node.js.

...

<PartnersList size="large" category="infrastructure" />
<PartnersList size="large" category="infrastruktur" />
Copy link
Member

@araujogui araujogui Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think category should be translated.

Copy link
Member

@araujogui araujogui Jan 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prop type is 'infrastructure' | 'esp'

Copy link
Member

@AugustinMauroy AugustinMauroy Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we always said "don't translate mdx propos" I didn't have perm for that. maybe @avivkeller @bmuenzenmeyer

Copy link

@sentry sentry bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The category prop for PartnersList was translated to "infrastruktur", which is an invalid value. This will cause the component to display no partners in that section.
Severity: HIGH

Suggested Fix

Revert the category prop value in apps/site/pages/id/about/partners.mdx from "infrastruktur" back to "infrastructure". Prop values like this should be treated as code, not translatable text, and should be excluded from translation synchronization processes.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/site/pages/id/about/partners.mdx#L19

Potential issue: The `PartnersList` component on the Indonesian partners page
(`id/about/partners.mdx`) has its `category` prop set to `"infrastruktur"`. This is an
invalid value according to the `PartnerCategory` type, which only allows
`'infrastructure'` or `'esp'`. The component filters partners from `constants.json`
using this prop value. Since no partner data contains the category `"infrastruktur"`,
the filter will return an empty array, causing the "Infrastructure Partners" section to
be empty for users viewing the Indonesian version of the site. This was likely caused by
an automated translation process incorrectly changing a programmatic value.

Did we get this right? 👍 / 👎 to inform future reviews.


## Pendukung

Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@node-core/website-i18n",
"version": "1.1.17",
"version": "1.1.18",
"type": "module",
"exports": {
"./*": [
Expand Down
8 changes: 7 additions & 1 deletion packages/i18n/src/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,13 @@
"contribute": "Contribuer",
"contributeText": "Éditer cette page",
"viewAs": "Afficher en tant que",
"tableOfContents": "Table des matières"
"tableOfContents": "Table des matières",
"metadata": "Métadonnées de l'article"
},
"banner": {
"default": "Annonce",
"warning": "Avertissement",
"error": "Notification d'erreur"
},
"search": {
"searchPlaceholder": "Commencer à écrire...",
Expand Down
8 changes: 7 additions & 1 deletion packages/i18n/src/locales/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,13 @@
"contribute": "編集への協力",
"contributeText": "このページを編集",
"viewAs": "表示方法",
"tableOfContents": "目次"
"tableOfContents": "目次",
"metadata": "記事のメタデータ"
},
"banner": {
"default": "お知らせ",
"warning": "警告通知",
"error": "エラー通知"
},
"search": {
"searchPlaceholder": "入力を開始...",
Expand Down
Loading