Skip to content

Conversation

@abdelkabirouadoukou
Copy link

Pull Request

Description

Remove pride flag variant from logo component - this is a runtime environment, not appropriate place for political/social expressions.

Technical changes:

  • Set logoVariant to 'default' in site configuration
  • Remove 'pride' from LogoVariant TypeScript type
  • Remove pride variant from NodejsLogo Storybook stories
  • Remove pride-specific rendering logic from component
  • Update design system stories

Keep the logo component focused on technical branding only.

Note: If you want to add social/political variants again, please create a separate discussion/issue first to establish clear guidelines about what belongs in technical infrastructure vs. community spaces.

Validation

  • ✅ Logo component renders with default variant only
  • ✅ TypeScript compilation passes without pride variant references
  • ✅ Storybook stories updated and working
  • ✅ No console errors or warnings
  • ✅ Site builds successfully with updated configuration

Related Issues

N/A - Proactive cleanup to maintain technical focus

Check List

Remove pride flag variant from logo component - this is a runtime environment,
not appropriate place for political/social expressions.

Technical changes:
- Set logoVariant to 'default' in site configuration
- Remove 'pride' from LogoVariant TypeScript type
- Remove pride variant from NodejsLogo Storybook stories
- Remove pride-specific rendering logic from component
- Update design system stories

Keep the logo component focused on technical branding only.

Note: If you want to add social/political variants again, please create a
separate discussion/issue first to establish clear guidelines about what
belongs in technical infrastructure vs. community spaces.
@abdelkabirouadoukou abdelkabirouadoukou requested review from a team as code owners June 23, 2025 17:53
@vercel
Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 23, 2025 5:55pm

@avivkeller avivkeller closed this Jun 23, 2025
@nodejs nodejs locked as too heated and limited conversation to collaborators Jun 23, 2025
@ljharb
Copy link
Member

ljharb commented Jun 23, 2025

nodejs/node#53299

@MattIPv4
Copy link
Member

MattIPv4 commented Jun 23, 2025

Note: If you want to add social/political variants again, please create a separate discussion/issue first to establish clear guidelines about what belongs in technical infrastructure vs. community spaces.

Please see #6802

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants