Skip to content

Conversation

@Uaitt
Copy link
Contributor

@Uaitt Uaitt commented Apr 16, 2025

Description

This PR just corrects a small typo on the Node.js with WebAssembly article.

Basically, ie becomes i.e.

Why am I proposing this?
I am in the process or reading all the Node.js getting started articles, and I have seen that in all other places in the docs the form i.e. is used (as seen here: https://github.com/search?q=repo%3Anodejs%2Fnodejs.org%20%22i.e.%22&type=code).

While the form ie can be considered correct, a widely accepted rule of thumb is to be consistent, so either i.e. or ie everywhere. (https://english.stackexchange.com/questions/407270/is-ie-acceptable-or-must-it-always-be-i-e)

@Uaitt Uaitt requested a review from a team as a code owner April 16, 2025 11:41
@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 19, 2025 7:30am

@avivkeller
Copy link
Member

avivkeller commented Apr 16, 2025

@Uaitt Uaitt force-pushed the correct-typo-in-webassembly-article branch from de313ef to 7ab0d94 Compare April 17, 2025 13:12
@Uaitt Uaitt requested review from a team as code owners April 17, 2025 13:12
@Uaitt Uaitt force-pushed the correct-typo-in-webassembly-article branch from 7ab0d94 to 86e7f63 Compare April 17, 2025 13:14
@Uaitt Uaitt changed the title Correct typo on WebAssembly article Uniform usage of i.e. and e.g. across docs Apr 17, 2025
@Uaitt
Copy link
Contributor Author

Uaitt commented Apr 17, 2025

@avivkeller I have fixed all the other occurrences :)

@avivkeller avivkeller changed the title Uniform usage of i.e. and e.g. across docs fix(content): unify usage of i.e. and e.g. across docs Apr 17, 2025
@avivkeller avivkeller changed the title fix(content): unify usage of i.e. and e.g. across docs fix(content): unify usage of i.e. and e.g. Apr 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member

@Uaitt can you rebase? We updated some checks recently, and they need to be applied here (but they won't fail).

@Uaitt Uaitt force-pushed the correct-typo-in-webassembly-article branch from 86e7f63 to 5863a1c Compare April 19, 2025 07:28
@Uaitt
Copy link
Contributor Author

Uaitt commented Apr 19, 2025

@avivkeller done

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (c32c588) to head (5863a1c).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7653      +/-   ##
==========================================
+ Coverage   74.61%   74.62%   +0.01%     
==========================================
  Files          96       96              
  Lines        7689     7689              
  Branches      192      192              
==========================================
+ Hits         5737     5738       +1     
+ Misses       1950     1949       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Apr 29, 2025
Merged via the queue into nodejs:main with commit 91a533f Apr 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants