Skip to content

src,sqlite: fix filterFunc dangling reference #62281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geeksilva97 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

src,sqlite: fix filterFunc dangling reference #62281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f8bfd9
src,sqlite: fix filterFunc dangling reference
geeksilva97 Mar 16, 2026
a71936c
src: make linter happy
geeksilva97 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2157,7 +2157,8 @@ void DatabaseSync::ApplyChangeset(const FunctionCallbackInfo<Value>& args) {

Local<Function> filterFunc = filterValue.As<Function>();

context.filterCallback = [&](std::string_view item) -> bool {
context.filterCallback =
[env, db, filterFunc](std::string_view item) -> bool {
// If there was an error in the previous call to the filter's
// callback, we skip calling it again.
if (db->ignore_next_sqlite_error_) {
Expand Down
Loading