-
-
Notifications
You must be signed in to change notification settings - Fork 35.1k
v8: add heap profile API #62273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IlyasShabi
wants to merge
4
commits into
nodejs:main
Choose a base branch
from
IlyasShabi:ishabi/v8_heap_profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+534
−70
Open
v8: add heap profile API #62273
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| 'use strict'; | ||
|
|
||
| const { | ||
| validateBoolean, | ||
| validateInteger, | ||
| validateInt32, | ||
| validateObject, | ||
| } = require('internal/validators'); | ||
|
|
||
| const { | ||
| kSamplingNoFlags, | ||
| kSamplingForceGC, | ||
| kSamplingIncludeObjectsCollectedByMajorGC, | ||
| kSamplingIncludeObjectsCollectedByMinorGC, | ||
| } = internalBinding('v8'); | ||
|
|
||
| function normalizeHeapProfileOptions(options = {}) { | ||
| validateObject(options, 'options'); | ||
| const { | ||
| sampleInterval = 512 * 1024, | ||
| stackDepth = 16, | ||
| forceGC = false, | ||
| includeObjectsCollectedByMajorGC = false, | ||
| includeObjectsCollectedByMinorGC = false, | ||
| } = options; | ||
|
|
||
| validateInteger(sampleInterval, 'options.sampleInterval', 1); | ||
| validateInt32(stackDepth, 'options.stackDepth', 0); | ||
| validateBoolean(forceGC, 'options.forceGC'); | ||
| validateBoolean(includeObjectsCollectedByMajorGC, | ||
| 'options.includeObjectsCollectedByMajorGC'); | ||
| validateBoolean(includeObjectsCollectedByMinorGC, | ||
| 'options.includeObjectsCollectedByMinorGC'); | ||
|
|
||
| let flags = kSamplingNoFlags; | ||
| if (forceGC) flags |= kSamplingForceGC; | ||
| if (includeObjectsCollectedByMajorGC) { | ||
| flags |= kSamplingIncludeObjectsCollectedByMajorGC; | ||
| } | ||
| if (includeObjectsCollectedByMinorGC) { | ||
| flags |= kSamplingIncludeObjectsCollectedByMinorGC; | ||
| } | ||
|
|
||
| return { sampleInterval, stackDepth, flags }; | ||
| } | ||
|
|
||
| module.exports = { | ||
| normalizeHeapProfileOptions, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to return a Buffer instead. It'd give us more flexibility to add binary formats in the future. I'd like to add support at some point in the future for the pprof-derived format being defined in OpenTelemetry at the moment, which is a binary format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC
worker.stopHeapProfile()already returns a JSON since v22, so changing the return type to Buffer would be a breaking change. For now this PR keeps the main thread consistent with the worker.We could add a format option
{ format: 'json' | 'pprof' }in a follow up PR when binary format support is needed. wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, going for parity with the worker API. We could probably do something similar to
fs.readFile(path, encoding, cb)where the encoding value switches the result between a string and a buffer depending on the format. I thinkformat: 'json' | 'pprof'seems a suitable way to deal with that. 🙂