Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Renegade334
requested changes
Feb 15, 2026
Member
There was a problem hiding this comment.
This needs the unicode.h aspects of v8/v8@ee2873a to unblock gcc builds.
rmagrin
force-pushed
the
v8-backport-highway-ascii
branch
from
9acf475 to
eb0d45c
Compare
rmagrin
changed the title
Original commit message:
Reland "use highway to check and copy leading ascii"
This is a reland of commit a3e84e5f01540cec142f4d4f41f1921373c220e5
Original change's description:
> use highway to check and copy leading ascii
>
> Change-Id: I065532aeeee95273821aa1f25b5ffc5c5c23cbf1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7172479
> Reviewed-by: Patrick Thier <pthier@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Dan Carney <dcarney@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#103820}
Change-Id: I43b4ad18817eb52b701e112d2d0a5f685374ae1f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7184338
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Patrick Thier <pthier@chromium.org>
Commit-Queue: Dan Carney <dcarney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103865}
Refs: v8/v8@67507b2
rmagrin
force-pushed
the
v8-backport-highway-ascii
branch
from
eb0d45c to
a215fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks V8 commit
67507b2a88f4— Reland "use highway to check and copy leading ascii" (Dan Carney).Replaces
IsAsciiOneByteString+memcpywith HighwayWriteLeadingAsciiinUtf8::Encode, providing a faster ASCII fast path forWriteUtf8V2.CL: https://chromium-review.googlesource.com/c/v8/v8/+/7184338
This patch addresses part of the remaining ~30-40% performance gap in
WriteUtf8V2vs v22 after #61712 landed the initialsimdutf+memcpyfast path.Note: The upstream V8 commit places template specialization declarations inside the class body, which Clang accepts but GCC rejects ("explicit specialization in non-namespace scope"). This backport moves the specializations to namespace scope, matching the pattern of the existing
IsAsciiOneByteStringthey replace.Refs: #60719
Test plan