test_runner: support test order randomization#61747
Open
pmarchini wants to merge 4 commits intonodejs:mainfrom
Open
test_runner: support test order randomization#61747pmarchini wants to merge 4 commits intonodejs:mainfrom
pmarchini wants to merge 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
pmarchini
force-pushed
the
test_runner/deterministic-test-randomizer
branch
2 times, most recently
from
5556788 to
e6f9a59
Compare
pmarchini
added
test_runner
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61747 +/- ##
========================================
Coverage 89.75% 89.75%
========================================
Files 674 675 +1
Lines 204416 204828 +412
Branches 39285 39352 +67
========================================
+ Hits 183472 183851 +379
- Misses 13227 13257 +30
- Partials 7717 7720 +3
🚀 New features to boost your workflow:
|
pmarchini
force-pushed
the
test_runner/deterministic-test-randomizer
branch
from
e6f9a59 to
b3b2388
Compare
pmarchini
force-pushed
the
test_runner/deterministic-test-randomizer
branch
from
b3b2388 to
08db017
Compare
MoLow
reviewed
Feb 10, 2026
MoLow
reviewed
Feb 10, 2026
MoLow
reviewed
Feb 10, 2026
MoLow
reviewed
Feb 10, 2026
MoLow
reviewed
Feb 10, 2026
pmarchini
commented
Feb 10, 2026
pmarchini
force-pushed
the
test_runner/deterministic-test-randomizer
branch
from
2eeb519 to
08db017
Compare
pmarchini
force-pushed
the
test_runner/deterministic-test-randomizer
branch
from
08db017 to
4d626b6
Compare
pmarchini
commented
Feb 10, 2026
Collaborator
JakobJingleheimer
approved these changes
Feb 23, 2026
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
🙌
I see I'm late to the party. None of my comments are pressing :)
| ``` | ||
|
|
||
| Using suite-style APIs such as `describe()`/`it()` or `suite()`/`test()` | ||
| still allows randomization, because sibling tests are queued together. |
Member
There was a problem hiding this comment.
nit: I thiiink it should be "enqueued"? "queued" together means they wait together; enqueued together means they're added to a queue one-by-one setting up a sequence.
| @@ -191,6 +198,12 @@ function getRunArgs(path, { forceExit, | |||
| if (rerunFailuresFilePath) { | |||
| ArrayPrototypePush(runArgs, `--test-rerun-failures=${rerunFailuresFilePath}`); | |||
| } | |||
| if (randomize === true) { | |||
Member
There was a problem hiding this comment.
Related to the skip and todo discussion: should this check truthiness rather than strict?
Member
|
I couldn't find the actualCI failure, but Richard did: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/38847/RUN_SUBSET=3,nodes=win11-arm64-COMPILED_BY-vs2022_clang-arm64/testReport/junit/(root)/parallel/test_domain_abort_on_uncaught/ The failure looks legit? |
Collaborator
JakobJingleheimer
added
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deterministic randomization to the Node.js test runner at both levels:
--test-randomizeenables randomized execution, and--test-random-seed=<seed>replays the same order deterministically (and implicitly enables randomization).When no seed is provided, one is generated and printed in the summary so runs are easy to reproduce.