Skip to content

doc: reserve NMV 145 for Electron 41#61291

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
nikwen:nvm-electron-41
Jan 7, 2026
Merged

doc: reserve NMV 145 for Electron 41#61291
nodejs-github-bot merged 1 commit intonodejs:mainfrom
nikwen:nvm-electron-41

Conversation

@nikwen
Copy link
Contributor

@nikwen nikwen commented Jan 5, 2026

Reserves NMV 145 for Electron 41. Thank you! 🙂

Relevant Electron task.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 5, 2026
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2026
@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2026
@nikwen
Copy link
Contributor Author

nikwen commented Jan 7, 2026

Thank you for all your reviews! Do I need to do anything else to get this merged?

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2026
@nodejs-github-bot nodejs-github-bot merged commit a18f8c1 into nodejs:main Jan 7, 2026
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a18f8c1

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Jan 9, 2026
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
PR-URL: nodejs#61291
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 23, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61291
✔  Done loading data for nodejs/node/pull/61291
----------------------------------- PR info ------------------------------------
Title      doc: reserve NMV 145 for Electron 41 (#61291)
Author     Niklas Wenzel <dev@nikwen.de> (@nikwen)
Branch     nikwen:nvm-electron-41 -> nodejs:main
Labels     doc, author ready, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x
Commits    1
 - doc: reserve NMV 145 for Electron 41
Committers 1
 - Niklas Wenzel <dev@nikwen.de>
PR-URL: https://github.com/nodejs/node/pull/61291
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61291
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 Jan 2026 22:30:22 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3628671139
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3628738569
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3629250566
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61291#pullrequestreview-3629556786
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61291#pullrequestreview-3630579789
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61291#pullrequestreview-3630768130
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61291#pullrequestreview-3631746692
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3634379109
   ⚠  This PR was merged on Wed, 07 Jan 2026 22:34:50 GMT
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/22325389744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants