esm: ensure watch mode restarts after syntax errors

[Xstoudi]

Move watch dependency reporting earlier in module resolution to ensure file dependencies are tracked even when parsing fails.

Fixes: #61153

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (ce2ec3d) to head (91fddbe).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/modules/esm/loader.js	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61232      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208734   208743       +9     
  Branches    40271    40267       -4     
==========================================
- Hits       184823   184814       -9     
- Misses      15932    15948      +16     
- Partials     7979     7981       +2     

Files with missing lines	Coverage Δ
lib/internal/modules/esm/loader.js	96.96% <83.33%> (+<0.01%)	⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[marco-ippolito]

Can you add a test?

[Xstoudi]

Just added a test, let me know if that's too broad and shouldn't be tested through cli.

[marco-ippolito]

why wrapping in try catch? it shouldnt fail

[Xstoudi]

It's a try finally, not a try catch. It shouldn't fail but wether it does or doesn't, the child processed need to be killed. The same try-finally is used every time restart is used in the file, so I just reused it.