build: support building crates (temporal) on windows #61163

ShenHongFei · 2025-12-24T03:17:20Z

configure --v8-enable-temporal-support --with-ltcg --dest-cpu=x64 --clang-cl=20.1.8

Fixed an error when building crates.gyp on Windows, and correctly set the lib file extension and system library dependencies.

Current error

     Compiling temporal_rs v0.1.0
     Compiling temporal_capi v0.1.0
     Compiling node_crates v0.1.0 (D:\1\nodejs\deps\crates)
      Finished `release` profile [optimized] target(s) in 9.09s
E:\sdk\vs\MSBuild\Microsoft\VC\v180\Microsoft.CppCommon.targets(254,5): warning MSB8065: Custom build for item "Cargo.toml" succeeded, but specified output "d:\1\nodejs\out\release\obj\global_intermediate\release\libnode_crates.a" has not been created. This may cause incremental build to work incorrectly. [D:\1\nodejs\deps\crates\node_crates.vcxproj]

�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) NtReadFile [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\io\mod.rs:484
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::io::default_read_to_end::hae912e80507d6821)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\io\mod.rs:484
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::io::default_read_to_end::hfa170b960d79e0a1)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\pal\windows\handle.rs:155
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::pal::windows::handle::Handle::read_to_end::hcf0b8f778f1125e4)
  >>> referenced 1 more times
  
�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) RtlNtStatusToDosError [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\io\mod.rs:484
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::io::default_read_to_end::hae912e80507d6821)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\io\mod.rs:484
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::io::default_read_to_end::hfa170b960d79e0a1)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\fs\windows.rs:1362
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::fs::windows::remove_dir_all::hc765fc4a95a44ac9)
  >>> referenced 9 more times
  
�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) GetUserProfileDirectoryW [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\env.rs:644
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::env::home_dir::h208640d7371dbbd7)
  
�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) NtOpenFile [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\fs\windows.rs:1362
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::fs::windows::remove_dir_all::hc765fc4a95a44ac9)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\fs\windows.rs:1362
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::fs::windows::remove_dir_all::hc765fc4a95a44ac9)
  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\fs\windows\remove_dir_all.rs:101
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::fs::windows::remove_dir_all::open_link_no_reparse::hc86ad9e73694d67a)
  >>> referenced 3 more times
  
�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) NtCreateNamedPipeFile [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\pal\windows\pipe.rs:115
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::pal::windows::pipe::anon_pipe::hb590bfe084a23905)
  
�[31;1mlld-link : error : undefined symbol: __declspec(dllimport) NtWriteFile [D:\1\nodejs\tools\v8_gypfiles\mksnapshot.vcxproj]
�[m  >>> referenced by /rustc/ed61e7d7e242494fb7057f2657300d9e77bb4fcb/library\std\src\sys\pal\windows\handle.rs:314
  >>>               node_crates.lib(std-80c6612147140e42.std.fe2f9c68055895e3-cgu.0.rcgu.o):(std::sys::pal::windows::handle::Handle::synchronous_write::hadd9a6025901175c)

After repair

Node.js has been successfully built on windows

Temporal.Now.plainDateISO().toString() outputs '2025-12-24'

nodejs-github-bot · 2025-12-24T03:17:25Z

Review requested:

@nodejs/gyp
@nodejs/security-wg

ShenHongFei · 2025-12-24T03:23:31Z

related pr: #61072

@legendecas , could you please review this when you get a chance? Thanks!

deps/crates/crates.gyp

ShenHongFei · 2025-12-29T06:37:33Z

I've modified it as you suggested. One CI failed during the clang install step: E: Failed to fetch store:/var/lib/apt/lists/partial/ports.ubuntu.com_ubuntu-ports_dists_noble-updates_universe_dep11_Components-arm64.yml.xz Hash Sum mismatch.
It looks like it needs to be retried?

nodejs-github-bot · 2025-12-29T16:00:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70625/

nodejs-github-bot · 2025-12-29T20:43:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70628/

ShenHongFei · 2025-12-30T13:09:47Z

Could someone share the failure logs for node-test-commit? I can't access Jenkins. (missing the Overall/Read permission)

nodejs-github-bot · 2025-12-30T17:49:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70634/

legendecas · 2025-12-30T17:49:31Z

It's unrelated flakiness. I've resumed the CI.

nodejs-github-bot · 2026-01-02T01:57:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/61163 ✔ Done loading data for nodejs/node/pull/61163 ----------------------------------- PR info ------------------------------------ Title build: support building crates (temporal) on windows (#61163) Author 沈鸿飞 <shen.hongfei@outlook.com> (@ShenHongFei) Branch ShenHongFei:windows-crates-1 -> nodejs:main Labels author ready, needs-ci, dependencies Commits 2 - build: support building crates (temporal) on windows - update crates.gyp Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/61163 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61163 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 24 Dec 2025 03:17:20 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61163#pullrequestreview-3616195256 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-12-30T17:49:30Z: https://ci.nodejs.org/job/node-test-pull-request/70634/ - Querying data for job/node-test-pull-request/70634/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61163 From https://github.com/nodejs/node * branch refs/pull/61163/merge -> FETCH_HEAD ✔ Fetched commits as 0457bfee2c25..8688ba99edae -------------------------------------------------------------------------------- [main 7cf451e32b] build: support building crates (temporal) on windows Author: 沈鸿飞 <shen.hongfei@outlook.com> Date: Wed Dec 24 11:14:13 2025 +0800 1 file changed, 15 insertions(+), 2 deletions(-) [main 76e1c4a2ea] update crates.gyp Author: 沈鸿飞 <shen.hongfei@outlook.com> Date: Mon Dec 29 14:31:04 2025 +0800 1 file changed, 8 insertions(+), 12 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:2276) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- build: support building crates (temporal) on windows

PR-URL: #61163
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 3428321eee] build: support building crates (temporal) on windows
Author: 沈鸿飞 <shen.hongfei@outlook.com>
Date: Wed Dec 24 11:14:13 2025 +0800
1 file changed, 15 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
update crates.gyp

PR-URL: #61163
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 9acceb6355] update crates.gyp
Author: 沈鸿飞 <shen.hongfei@outlook.com>
Date: Mon Dec 29 14:31:04 2025 +0800
1 file changed, 8 insertions(+), 12 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/20649093966

ShenHongFei · 2026-01-02T03:29:10Z

Add commit-queue-squash label to land the PR as one commit

The bot suggests using the commit-queue-squash label.

nodejs-github-bot · 2026-01-02T15:30:16Z

Landed in ce444fa

build: support building crates (temporal) on windows

30141f1

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 24, 2025

legendecas approved these changes Dec 28, 2025

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2025

legendecas reviewed Dec 28, 2025

View reviewed changes

deps/crates/crates.gyp Outdated Show resolved Hide resolved

legendecas removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2025

update crates.gyp

8688ba9

legendecas approved these changes Dec 29, 2025

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2025

legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 31, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 2, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2026

nodejs-github-bot merged commit ce444fa into nodejs:main Jan 2, 2026
75 of 77 checks passed

Uh oh!

build: support building crates (temporal) on windows #61163

build: support building crates (temporal) on windows #61163

Conversation

ShenHongFei commented Dec 24, 2025

Current error

After repair

Uh oh!

nodejs-github-bot commented Dec 24, 2025

Uh oh!

ShenHongFei commented Dec 24, 2025

Uh oh!

Uh oh!

ShenHongFei commented Dec 29, 2025

Uh oh!

nodejs-github-bot commented Dec 29, 2025

Uh oh!

nodejs-github-bot commented Dec 29, 2025

Uh oh!

ShenHongFei commented Dec 30, 2025

Uh oh!

nodejs-github-bot commented Dec 30, 2025

Uh oh!

legendecas commented Dec 30, 2025

Uh oh!

nodejs-github-bot commented Jan 2, 2026

PR-URL: #61163 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61163 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 9acceb6355] update crates.gyp Author: 沈鸿飞 <shen.hongfei@outlook.com> Date: Mon Dec 29 14:31:04 2025 +0800 1 file changed, 8 insertions(+), 12 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

ShenHongFei commented Jan 2, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PR-URL: #61163
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #61163
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

[detached HEAD 9acceb6355] update crates.gyp
Author: 沈鸿飞 <shen.hongfei@outlook.com>
Date: Mon Dec 29 14:31:04 2025 +0800
1 file changed, 8 insertions(+), 12 deletions(-)
Successfully rebased and updated refs/heads/main.