-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
src: dump snapshot source with node:generate_default_snapshot_source #61101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joyeecheung
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
joyeecheung:snapshot-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps diffing snapshots when the reproducibility gets broken.
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61101 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 703 703
Lines 208546 208552 +6
Branches 40217 40221 +4
==========================================
- Hits 184634 184601 -33
- Misses 15926 15944 +18
- Partials 7986 8007 +21
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Dec 19, 2025
Member
Author
|
Removed the unused file and added back the helper (turns out it's still used to format stderr during failures). |
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: dump snapshot source with node:generate_default_snapshot_source ⚠ - fixup! src: dump snapshot source with node:generate_default_snapshot_… ⚠ - fixup! fixup! src: dump snapshot source with node:generate_default_sn… ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20415476248 |
addaleax
approved these changes
Jan 1, 2026
legendecas
approved these changes
Jan 2, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps diffing snapshots when the reproducibility gets broken.