-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
Add --max-heap-size option #58708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add --max-heap-size option #58708
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58708 +/- ##
==========================================
- Coverage 90.16% 89.91% -0.26%
==========================================
Files 637 655 +18
Lines 188001 192830 +4829
Branches 36881 37791 +910
==========================================
+ Hits 169509 173379 +3870
- Misses 11238 12004 +766
- Partials 7254 7447 +193
🚀 New features to boost your workflow:
|
|
Hey @tannal, great job on putting together this PR 🚀 Just a quick heads-up: there's a specific process the project follows for making changes, including commit message formatting and code style guidelines. You can check it out here: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes Totally happy to help if you need a hand navigating any of it, feel free to reach out! |
0dd92b4 to
1e23624
Compare
|
@tannal Can I open a new PR to fix this issue? |
It's up to you. I don't think we need another pr. |
This PR fixs #58686