Skip to content

Conversation

@tannal
Copy link
Contributor

@tannal tannal commented Jun 14, 2025

This PR fixs #58686

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Jun 14, 2025
@codecov
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (5fe7800) to head (a57cee3).
⚠️ Report is 1341 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58708      +/-   ##
==========================================
- Coverage   90.16%   89.91%   -0.26%     
==========================================
  Files         637      655      +18     
  Lines      188001   192830    +4829     
  Branches    36881    37791     +910     
==========================================
+ Hits       169509   173379    +3870     
- Misses      11238    12004     +766     
- Partials     7254     7447     +193     
Files with missing lines Coverage Δ
src/node_options.cc 84.71% <100.00%> (+0.26%) ⬆️

... and 211 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lluisemper
Copy link
Contributor

Hey @tannal, great job on putting together this PR 🚀

Just a quick heads-up: there's a specific process the project follows for making changes, including commit message formatting and code style guidelines. You can check it out here: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes

Totally happy to help if you need a hand navigating any of it, feel free to reach out!

@tannal tannal force-pushed the option branch 2 times, most recently from 0dd92b4 to 1e23624 Compare August 7, 2025 11:11
@haramj
Copy link
Member

haramj commented Sep 21, 2025

@tannal Can I open a new PR to fix this issue?

@tannal
Copy link
Contributor Author

tannal commented Sep 22, 2025

@tannal Can I open a new PR to fix this issue?

It's up to you. I don't think we need another pr.

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants