Feat/add vs2026 support #3224
Closed
Feat/add vs2026 support #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@StefanStojanovic, your review please. There are an increasing number of Visual Studio not found issues. |
Closed
Contributor
Member
|
@StefanStojanovic @cclauss Yeah I think that's what we agreed upon previously. Once landed and released in gyp-next there's a workflow that will automatically update them in this repo. While on the topic: what do either of you think about a PR check that would detect changes to the |
Member
|
Closing this in favor of #3236 |
Member
|
#3236 is now merged and the next release will have support for VS2026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
feat: add support for Visual Studio 2026
This pull request introduces initial support for the upcoming Visual Studio 2026 (internal version 18.0).
The key changes include:
SelectVisualStudioVersionand_DetectVisualStudioVersions. This allows GYP to correctly identify VS 2026 installations.VisualStudioVersiondefinition for '2026' in the_CreateVersionfunction.default_toolsettov145. This aligns with the toolset version observed in the Visual Studio 2026 Insider Preview builds, resolving potentialMSB8020errors for users on the latest previews.These changes enable developers using early versions of Visual Studio 2026 to generate and build projects with GYP seamlessly.