port test_finalizer#55
Draft
bavulapati wants to merge 7 commits intonodejs:mainfrom
Draft
Conversation
Member
|
@bavulapati I suggest keeping stacked PRs in draft until their parent PRs merge 👍 |
Contributor
Author
|
depends on #53 |
PORTING.md: keep both new "Ported" rows (test_finalizer from this branch, test_function from main). implementors/node/tests.ts: take this branch's spawnTest-based design. implementors/node/child_process.js: extend HARNESS_MODULE_PATHS with the skip-test.js and napi-version.js harness modules main introduced. tests/harness/spawn-test.js: forward --expose-gc to spawnTest children that should succeed, since main tightened gc.js to refuse loading without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.