Skip to content

Conversation

@toyobayashi
Copy link
Contributor

@Ben08300
Copy link

Ben08300 commented May 27, 2025

Hi,
Just wanted to tell that I've tested the above changes.

Compilation now runs smoothly and just displays a warning (which is expected according to the PR):

Warning: failed to get compiler predefines
cmd: ['cl.exe', '-dM', '-E', '-x', 'c', 'C:\\Users\\benja\\AppData\\Local\\Temp\\tmp0rvxkp3m.c']
status: 2

Any ETA regarding the next gyp-next and node-gyp releases ?
Thanks again for your reactivity.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test case covering that the command fails? Thank you!

@toyobayashi
Copy link
Contributor Author

Done.

@toyobayashi toyobayashi requested a review from legendecas May 29, 2025 04:45
@legendecas legendecas requested a review from cclauss May 29, 2025 13:44
@legendecas legendecas merged commit 0eaea29 into nodejs:main Jun 6, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native addon compilation using node-gyp >= 10.2.0 Native addon compilation using node-gyp >= 10.2.0 (gyp-next >= v0.18.1)

3 participants