test: add missing coverage for json parser, url utils, and generator …#679
Open
ryzrr wants to merge 1 commit intonodejs:mainfrom
Open
test: add missing coverage for json parser, url utils, and generator …#679ryzrr wants to merge 1 commit intonodejs:mainfrom
ryzrr wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing/expanded unit tests to raise coverage for low-covered utility/parser modules, aligning with the project’s minimum coverage requirement.
Changes:
- Added
src/parsers/__tests__/json.test.mjsto coverparseTypeMap(falsy path, valid JSON, invalid JSON). - Added
src/utils/__tests__/url.test.mjsto covertoParsedURLandloadFromURLfor file paths,file:URLs, and http(s) fetch. - Expanded
src/utils/__tests__/generators.test.mjscoverage forlegacyToJSON,buildApiDocURL, andcreateLazyGenerator.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/tests/url.test.mjs | New tests for URL parsing and URL/file loading behavior with fs/fetch mocking. |
| src/utils/tests/generators.test.mjs | Additional tests for generator utilities and lazy generator delegation (with dynamic import mocking). |
| src/parsers/tests/json.test.mjs | New tests for JSON type-map parsing with mocked loadFromURL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 74.37% 75.68% +1.31%
==========================================
Files 146 148 +2
Lines 13376 13556 +180
Branches 967 1009 +42
==========================================
+ Hits 9948 10260 +312
+ Misses 3422 3290 -132
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivkeller
force-pushed
the
test/missing-coverage
branch
from
7dd752a to
841dad2
Compare
Member
|
Rebased for Codecov to generate a report |
Member
|
Hmm, maybe Codecov is partially down, or something. coverage report: |
Author
|
Thanks for the rebase and running the report manually! Lemme know if there's anything else you'd like me to address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three modules had no or partial test coverage, below the 80% minimum the project requires.
```
src/parsers/json.mjs 0% → 100%
src/utils/generators.mjs 77% → 100%
src/utils/url.mjs 50% → 70%
```
New test files follow the existing conventions (
node:test,mock.module()for dependency isolation,import.meta.resolve()for accurate mock paths).Validation
Run
node --run test:coverageto verify. All 339 tests pass, no regressions.Related Issues
No related issue, proactive coverage fix.
Check List
node --run testand all tests passed.node --run format&node --run lint.